Document nmstate as experimental and require an override to use it

[slagle]

"edpm_network_config_tool: nmstate" is experimental and officially
unsupported. This change will require users to explicitly opt-in to
using nmstate directly instead of using os-net-config+nmstate. It adds a
task that will fail unless edpm_network_config_tool_nmstate_override is
set to true (defaults to false).

Signed-off-by: James Slagle [email protected]
Jira: https://issues.redhat.com/browse/OSPRH-12316

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6de467403e2c4c3e9b69d53848c75034

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 29m 45s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 36s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 33m 47s
✔️ edpm-ansible-tempest-multinode SUCCESS in 1h 54m 35s
❌ edpm-ansible-molecule-edpm_bootstrap FAILURE in 4m 11s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 4m 58s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 4m 01s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 7m 30s
❌ edpm-ansible-molecule-edpm_libvirt FAILURE in 4m 07s
❌ edpm-ansible-molecule-edpm_nova FAILURE in 4m 05s
❌ edpm-ansible-molecule-edpm_frr FAILURE in 3m 59s
✔️ edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 11s
❌ edpm-ansible-molecule-edpm_ovn_bgp_agent FAILURE in 4m 00s
❌ edpm-ansible-molecule-edpm_ovs FAILURE in 4m 36s
✔️ edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 3m 33s
❌ edpm-ansible-molecule-edpm_tuned FAILURE in 4m 15s
❌ edpm-ansible-molecule-edpm_telemetry_power_monitoring FAILURE in 4m 37s
❌ edpm-ansible-molecule-edpm_update FAILURE in 3m 56s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 3h 08m 45s

[bshephar]

Do you think more things like this are likely to come up in the future?

I wonder if a better approach might be to have a dictionary called something like edpm_tech_preview. Then allow users to enable tech preview features be appending them to the list?

Obviously, this isn't required if we're only doing it for nmstate. But I do wonder how many more of these things will come up in the future and how cumbersome it will become to individually manage them on a per role basis?

Similar to feature gates I guess:
https://docs.openshift.com/container-platform/4.17/nodes/clusters/nodes-cluster-enabling-features.html

https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/

Could be overkill for our requirements, but putting it out there for consideration.

[slagle]

Do you think more things like this are likely to come up in the future?

I wonder if a better approach might be to have a dictionary called something like edpm_tech_preview. Then allow users to enable tech preview features be appending them to the list?

Obviously, this isn't required if we're only doing it for nmstate. But I do wonder how many more of these things will come up in the future and how cumbersome it will become to individually manage them on a per role basis?

Similar to feature gates I guess: https://docs.openshift.com/container-platform/4.17/nodes/clusters/nodes-cluster-enabling-features.html

https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/

Could be overkill for our requirements, but putting it out there for consideration.

Yes, I could see adding a field like this on the NodeSet, which would set an ansible var to enable certain features. I think it would consider it separately from this PR

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bshephar,slagle]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vcandapp]

ltgm