Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent NM from automatic (DHCP) configuration on ethernet devices #840

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vcandapp
Copy link
Contributor

@vcandapp vcandapp commented Dec 6, 2024

When edpm_network_config role uses os-net-config to perform host network configuration, duplicate DHCP requests from NM are causing connectivity issue. Eg.

https://issues.redhat.com/browse/OSPRH-9142

This fix prevents NM from configure DHCP by default

This PR replaces an older PR

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8bab6f5338bf4df098ad15cf4097cc52

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 03m 14s
podified-multinode-edpm-deployment-crc FAILURE in 1h 46m 12s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 13m 34s
edpm-ansible-tempest-multinode FAILURE in 1h 52m 54s
✔️ edpm-ansible-molecule-edpm_bootstrap SUCCESS in 8m 49s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 44s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 4m 58s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 10m 50s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 10m 19s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 12m 45s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 8m 48s
✔️ edpm-ansible-molecule-edpm_iscsid SUCCESS in 5m 16s
✔️ edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 9m 16s
✔️ edpm-ansible-molecule-edpm_ovs SUCCESS in 12m 39s
✔️ edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 4m 33s
✔️ edpm-ansible-molecule-edpm_tuned SUCCESS in 6m 38s
✔️ edpm-ansible-molecule-edpm_telemetry_power_monitoring SUCCESS in 8m 43s
✔️ edpm-ansible-molecule-edpm_update SUCCESS in 8m 10s
adoption-standalone-to-crc-ceph-provider FAILURE in 2h 37m 44s

@vcandapp vcandapp changed the title Prevent NM from automatic (DHCP/SLAAC) configuration on ethernet devices Prevent NM from automatic (DHCP) configuration on ethernet devices Dec 6, 2024
@vcandapp vcandapp force-pushed the jira_OSPRH_9142 branch 2 times, most recently from fbda264 to c38781c Compare December 9, 2024 09:52
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/83f722bae5704a5d8df2109efac023a2

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 01m 59s
podified-multinode-edpm-deployment-crc FAILURE in 1h 46m 27s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 39m 00s
edpm-ansible-tempest-multinode FAILURE in 1h 52m 06s
✔️ edpm-ansible-molecule-edpm_bootstrap SUCCESS in 6m 00s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 4m 57s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 3m 57s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 7m 31s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 8m 03s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 8m 41s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 6m 06s
✔️ edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 03s
✔️ edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 6m 36s
✔️ edpm-ansible-molecule-edpm_ovs SUCCESS in 11m 52s
✔️ edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 3m 36s
✔️ edpm-ansible-molecule-edpm_tuned SUCCESS in 6m 04s
✔️ edpm-ansible-molecule-edpm_telemetry_power_monitoring SUCCESS in 6m 53s
✔️ edpm-ansible-molecule-edpm_update SUCCESS in 6m 35s
adoption-standalone-to-crc-ceph-provider FAILURE in 2h 38m 03s

@vcandapp
Copy link
Contributor Author

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/07c572991265451d87665d5763b33d35

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 17m 06s
podified-multinode-edpm-deployment-crc FAILURE in 1h 42m 33s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 24m 02s
edpm-ansible-tempest-multinode FAILURE in 1h 51m 46s
✔️ edpm-ansible-molecule-edpm_bootstrap SUCCESS in 5m 56s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 11s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 4m 19s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 7m 41s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 7m 52s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 9m 06s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 6m 09s
✔️ edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 09s
✔️ edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 6m 35s
✔️ edpm-ansible-molecule-edpm_ovs SUCCESS in 12m 29s
✔️ edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 3m 38s
✔️ edpm-ansible-molecule-edpm_tuned SUCCESS in 5m 58s
✔️ edpm-ansible-molecule-edpm_telemetry_power_monitoring SUCCESS in 7m 02s
✔️ edpm-ansible-molecule-edpm_update SUCCESS in 6m 54s
adoption-standalone-to-crc-ceph-provider FAILURE in 2h 36m 49s

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c82a5d5670d746b3b2e53cd715f2d333

✔️ openstack-k8s-operators-content-provider SUCCESS in 4h 22m 15s
podified-multinode-edpm-deployment-crc FAILURE in 1h 43m 53s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 42m 30s
edpm-ansible-tempest-multinode FAILURE in 1h 50m 44s
✔️ edpm-ansible-molecule-edpm_bootstrap SUCCESS in 7m 11s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 48s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 4m 49s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 9m 57s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 9m 41s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 10m 34s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 6m 57s
✔️ edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 49s
✔️ edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 7m 44s
✔️ edpm-ansible-molecule-edpm_ovs SUCCESS in 12m 10s
✔️ edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 4m 17s
✔️ edpm-ansible-molecule-edpm_tuned SUCCESS in 6m 17s
✔️ edpm-ansible-molecule-edpm_telemetry_power_monitoring SUCCESS in 7m 57s
✔️ edpm-ansible-molecule-edpm_update SUCCESS in 6m 24s
adoption-standalone-to-crc-ceph-provider FAILURE in 2h 42m 04s

When edpm_network_config role uses os-net-config to perform
host network configuration, duplicate DHCP requests from NM are causing
issue. Eg.
https://issues.redhat.com/browse/OSPRH-9142

This fix prevents NM to configure DHCP by default
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2210ee8b60fd4e8ba2e12bce3f12d892

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 34m 57s
podified-multinode-edpm-deployment-crc FAILURE in 1h 47m 58s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 51m 58s
edpm-ansible-tempest-multinode FAILURE in 1h 53m 22s
✔️ edpm-ansible-molecule-edpm_bootstrap SUCCESS in 6m 51s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 07s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 02s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 6m 48s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 9m 34s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 11m 46s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 8m 56s
✔️ edpm-ansible-molecule-edpm_iscsid SUCCESS in 5m 49s
✔️ edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 9m 26s
✔️ edpm-ansible-molecule-edpm_ovs SUCCESS in 12m 30s
✔️ edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 4m 53s
✔️ edpm-ansible-molecule-edpm_tuned SUCCESS in 6m 07s
✔️ edpm-ansible-molecule-edpm_telemetry_power_monitoring SUCCESS in 9m 25s
✔️ edpm-ansible-molecule-edpm_update SUCCESS in 6m 33s
adoption-standalone-to-crc-ceph-provider FAILURE in 2h 52m 42s

Copy link
Contributor

openshift-ci bot commented Dec 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar, slagle, vcandapp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bshephar
Copy link
Contributor

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8d1574cb858144ebb5d467b726f28e91

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 56m 31s
podified-multinode-edpm-deployment-crc FAILURE in 1h 43m 38s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 40m 15s
edpm-ansible-tempest-multinode FAILURE in 1h 48m 03s
✔️ edpm-ansible-molecule-edpm_bootstrap SUCCESS in 6m 55s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 05s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 4m 40s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 10m 05s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 9m 37s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 9m 01s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 6m 17s
✔️ edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 38s
✔️ edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 7m 41s
✔️ edpm-ansible-molecule-edpm_ovs SUCCESS in 13m 23s
✔️ edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 3m 31s
✔️ edpm-ansible-molecule-edpm_tuned SUCCESS in 6m 32s
✔️ edpm-ansible-molecule-edpm_telemetry_power_monitoring SUCCESS in 7m 10s
✔️ edpm-ansible-molecule-edpm_update SUCCESS in 6m 40s
adoption-standalone-to-crc-ceph-provider FAILURE in 2h 34m 32s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants