Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci_gen_kustomize_values] Add mac address mapping for nic1 #1390

Merged

Conversation

rebtoor
Copy link
Contributor

@rebtoor rebtoor commented Apr 3, 2024

This patch allow the mapping of the nic1 to the mac address of the default interface in compute node and is required due to [1]

[1] openstack-k8s-operators/architecture#157

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

Copy link
Contributor

openshift-ci bot commented Apr 3, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/64ab4f35205b4c219f2aba1699721e9a

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 38m 33s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 06m 47s
✔️ noop SUCCESS in 0s
cifmw-molecule-ci_gen_kustomize_values FAILURE in 4m 58s

Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@rebtoor
Copy link
Contributor Author

rebtoor commented Apr 4, 2024

/test all

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/473bca70f95d4f7697362fa0e8845430

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 29m 58s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 09m 05s
✔️ noop SUCCESS in 0s
cifmw-molecule-ci_gen_kustomize_values FAILURE in 4m 48s

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/37fa0bc646cd4c568800ef0b60d2ed5f

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 27m 30s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 08m 56s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 15s (non-voting)
cifmw-molecule-ci_gen_kustomize_values FAILURE in 4m 43s

@rebtoor
Copy link
Contributor Author

rebtoor commented Apr 8, 2024

[zuul@controller-0 ~]$ grep 'nic1:' ~/ci-framework-data/artifacts/ci_gen_kustomize_values/edpm-values/values.yaml 
                        nic1: 52:54:00:b2:8a:98
                        nic1: 52:54:00:63:73:db
                        nic1: 52:54:00:53:b5:ef
[zuul@controller-0 ~]$ for i in {0..2};do ssh compute-${i} ip link show eth0|awk '$0 ~/link/ {print $2}' 2>/dev/null;done
Warning: Permanently added '192.168.111.52' (ED25519) to the list of known hosts.
52:54:00:b2:8a:98
Warning: Permanently added '192.168.111.34' (ED25519) to the list of known hosts.
52:54:00:63:73:db
Warning: Permanently added '192.168.111.31' (ED25519) to the list of known hosts.
52:54:00:53:b5:ef

@rebtoor rebtoor marked this pull request as ready for review April 8, 2024 11:57
@rebtoor rebtoor requested review from pablintino and cjeanner and removed request for rachael-george and adrianfusco April 8, 2024 11:57
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/8c75f32314944995b8573f9c00757be4

✔️ openstack-k8s-operators-content-provider SUCCESS in 29m 16s
podified-multinode-edpm-deployment-crc RETRY_LIMIT in 10m 57s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 37s (non-voting)
✔️ cifmw-molecule-ci_gen_kustomize_values SUCCESS in 5m 17s

@rebtoor
Copy link
Contributor Author

rebtoor commented Apr 8, 2024

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/f8fca0f959e342448d41cc1d6434808f

✔️ openstack-k8s-operators-content-provider SUCCESS in 28m 50s
podified-multinode-edpm-deployment-crc RETRY_LIMIT in 11m 33s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 49s (non-voting)
✔️ cifmw-molecule-ci_gen_kustomize_values SUCCESS in 5m 00s

@cjeanner
Copy link
Collaborator

cjeanner commented Apr 8, 2024

/approve

@cjeanner
Copy link
Collaborator

cjeanner commented Apr 8, 2024

I could successfully generate the snippet on my end, and it correctly listed the NIC.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/3628f15198504a02a1b86fbcd5edeb0a

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 17m 30s
podified-multinode-edpm-deployment-crc FAILURE in 55m 30s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-pre-commit SUCCESS in 9m 29s (non-voting)
✔️ cifmw-molecule-ci_gen_kustomize_values SUCCESS in 5m 03s

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/98fbdda404d44336b5f81994ed33f48d

✔️ openstack-k8s-operators-content-provider SUCCESS in 24m 39s
podified-multinode-edpm-deployment-crc MERGE_CONFLICT in 3s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 54s (non-voting)
✔️ cifmw-molecule-ci_gen_kustomize_values SUCCESS in 5m 00s

This patch allow the mapping of the `nic1` to the mac address of the
default interface in compute node and is required due to [1]

[1] openstack-k8s-operators/architecture#157

Signed-off-by: Roberto Alfieri <[email protected]>
@pablintino
Copy link
Collaborator

/approve

Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjeanner, pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cjeanner,pablintino]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cjeanner
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d9c92e3 into openstack-k8s-operators:main Apr 10, 2024
7 checks passed
@rebtoor rebtoor deleted the fix-nic1-dhcp branch September 23, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants