parseQueryString() is using deprecated unescape() #64
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Deprecated_and_obsolete_features > The escape and unescape functions are deprecated. Use encodeURI, > encodeURIComponent, decodeURI or decodeURIComponent to encode and decode > escape sequences for special characters. The problem I had with it is was with accented characters: ``` > str = encodeURIComponent("Yaoundé 6") "Yaound%C3%A9%206" > unescape(str) "Yaoundé 6" > decodeURIComponent(str) "Yaoundé 6" ``` This won't happen if we've used `escape(str)` instead of `encodeURIComponent()`, but the encoded string that comes from the `window.location`, for example, uses the codification as `encodeURIComponent()`. There's a good comparison about these methods in http://xkr.us/articles/javascript/encode-compare/
vitorbaptista
added a commit
to openspending/cameroon.openspending.org
that referenced
this pull request
Jun 4, 2014
This was needed to get the fix at openspending-archive/openspendingjs#64 . We're using the 64-deprecated-unescape branch, but should move to master whenever that's merged.
|
@akariv Is this repository still used? |
|
Never heard of it
…On Wed, Jul 19, 2017 at 3:45 PM Vitor Baptista ***@***.***> wrote:
@akariv <https://github.com/akariv> Is this repository still used?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#64 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAQMddb08hH42-vA12srqgtKsNJDt1lVks5sPfp8gaJpZM4CBBtg>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Deprecated_and_obsolete_features
The problem I had with it is was with accented characters:
This won't happen if we've used
escape(str)instead ofencodeURIComponent(), but the encoded string that comes from thewindow.location, for example, uses the codification asencodeURIComponent().There's a good comparison about these methods in http://xkr.us/articles/javascript/encode-compare/