Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: automatically create GitHub release when tagged #67

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

bgilbert
Copy link
Member

Run meson dist on Linux in every build, because it's a good idea to test this and because the build job already installs the dependencies for meson setup. Archive the artifact, then conditionally run a second job to do the release.

This uses the same release-job pattern as OpenSlide Python, rather than starting a second workflow upon completion of the build workflow. This results in a skipped job in every PR's job list, but allows the passing of output variables between jobs.

Linux builds run in ubuntu-latest, not in a Fedora container, so the Autotools blobs in the source tarball will be generated on Ubuntu 22.04. That release has current versions of Autoconf and Automake, so this seems okay.

@openslide-bot
Copy link

openslide-bot commented Mar 30, 2024

DCO signed off ✔️

All commits have been signed off. You have certified to the terms of the Developer Certificate of Origin, version 1.1. In particular, you certify that this contribution has not been developed using information obtained under a non-disclosure agreement or other license terms that forbid you from contributing it under the GNU Lesser General Public License, version 2.1.

Run `meson dist` on Linux in every build, because it's a good idea to test
this and because the build job already installs the dependencies for
`meson setup`.  Archive the artifact, then conditionally run a second job
to do the release.

This uses the same release-job pattern as OpenSlide Python, rather than
starting a second workflow upon completion of the build workflow.  This
results in a skipped job in every PR's job list, but allows the passing of
output variables between jobs.

Linux builds run in ubuntu-latest, not in a Fedora container, so the
Autotools blobs in the source tarball will be generated on Ubuntu 22.04.
That release has current versions of Autoconf and Automake, so this seems
okay.

Signed-off-by: Benjamin Gilbert <[email protected]>
@bgilbert bgilbert merged commit aabc7fc into openslide:main Apr 4, 2024
4 checks passed
@bgilbert bgilbert deleted the autorelease branch April 4, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants