Fix incorrect rolebinding error message and improve logging #2564
Conversation
This commit introduces a log to print the platform type of the cluster to enhance the WMCO pod log for better triage.
This commit improve the WICD roleBinding and clusterRoleBinding creation log messages with addition information for better correlation.
This commit adjust the roleBinding creation log message to correctly show the namespace of the malformed resource existing in the cluster.
|
/test remaining-required |
| meta.CreateOptions{}) | ||
| if err != nil { | ||
| return fmt.Errorf("unable to create RoleBinding %s/%s: %w", r.watchNamespace, wicdRBACResourceName, err) | ||
| } | ||
| r.log.Info("Created resource", "RoleBinding", | ||
| kubeTypes.NamespacedName{Namespace: r.watchNamespace, Name: expectedRB.Name}) | ||
| kubeTypes.NamespacedName{Namespace: createdRB.Namespace, Name: createdRB.Name}, |
There was a problem hiding this comment.
wouldn't this be same as expectedRB?
There was a problem hiding this comment.
Yes, with namespaced resources isn't a big deal. I made this change to better align with the ClusterRoleBinding log messages.
|
/test aws-e2e-operator |
|
/retest-required |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jrvaldes, sebsoto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
vsphere-e2e-operator job failed but wmco test suite passed @openshift/openshift-team-windows-containers Please consider overriding the failed jobs |
|
/lgtm |
|
/override ci/prow/vsphere-e2e-operator ci/prow/vsphere-disconnected-e2e-operator |
|
@mansikulkarni96: Overrode contexts on behalf of mansikulkarni96: ci/prow/vsphere-disconnected-e2e-operator, ci/prow/vsphere-e2e-operator In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test azure-e2e-operator timed out |
|
/test azure-e2e-operator to gather more data |
3 similar comments
|
/test azure-e2e-operator |
5 similar comments
|
/test azure-e2e-operator |
|
/test vsphere-e2e-operator |
|
/hold Revision a739d43 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/test azure-e2e-operator |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required |
|
@jrvaldes: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR introduces fixes and improvements to the logging messages in both the
cmdandcontrollerpackages to enhance debugging capabilities. Particularly, correct the log message for RB deletion to show the namespace of the malformed resource properly.