Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.17] Prevent some submodule auto-updates #2546

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

sebsoto
Copy link
Contributor

@sebsoto sebsoto commented Nov 22, 2024

Adds a renovate.json from
https://github.com/konflux-ci/mintmaker/blob/main/config/renovate/renovate.json

This is the default config that konflux uses. I added an ignoreDeps field to prevent the kubelet, kube-proxy, and containerd submodules from being updated automatically. This is because they need to be updated using hack/update-submodules.sh, in order to present the correct versioning.

Adds a renovate.json from
https://github.com/konflux-ci/mintmaker/blob/main/config/renovate/renovate.json

This is the default config that konflux uses. I added an ignoreDeps
field to prevent the kubelet, kube-proxy, and containerd submodules from
being updated automatically. This is because they need to be updated
using hack/update-submodules.sh, in order to present the correct
versioning.
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2024
Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2024
@sebsoto sebsoto marked this pull request as ready for review November 22, 2024 19:28
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2024
Copy link
Contributor

@jrvaldes jrvaldes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

"at any time"
]
},
"ignoreDeps": ["kubelet/", "kube-proxy/","containerd/"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ovn-kubernetes ?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2024
Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrvaldes, sebsoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 518addb and 2 for PR HEAD 2b1d39a in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 87b320f and 1 for PR HEAD 2b1d39a in total

@sebsoto
Copy link
Contributor Author

sebsoto commented Nov 22, 2024

/override ci/prow/aws-e2e-operator ci/prow/azure-e2e-operator ci/prow/azure-e2e-upgrade ci/prow/gcp-e2e-operator ci/prow/nutanix-e2e-operator ci/prow/platform-none-vsphere-e2e-operator ci/prow/vsphere-proxy-e2e-operator ci/prow/vsphere-e2e-operator ci/prow/wicd-unit-vsphere ci/prow/vsphere-disconnected-e2e-operator

Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

@sebsoto: Overrode contexts on behalf of sebsoto: ci/prow/aws-e2e-operator, ci/prow/azure-e2e-operator, ci/prow/azure-e2e-upgrade, ci/prow/gcp-e2e-operator, ci/prow/nutanix-e2e-operator, ci/prow/platform-none-vsphere-e2e-operator, ci/prow/vsphere-disconnected-e2e-operator, ci/prow/vsphere-e2e-operator, ci/prow/vsphere-proxy-e2e-operator, ci/prow/wicd-unit-vsphere

In response to this:

/override ci/prow/aws-e2e-operator ci/prow/azure-e2e-operator ci/prow/azure-e2e-upgrade ci/prow/gcp-e2e-operator ci/prow/nutanix-e2e-operator ci/prow/platform-none-vsphere-e2e-operator ci/prow/vsphere-proxy-e2e-operator ci/prow/vsphere-e2e-operator ci/prow/wicd-unit-vsphere ci/prow/vsphere-disconnected-e2e-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 646b0ff into openshift:release-4.17 Nov 22, 2024
19 checks passed
@sebsoto
Copy link
Contributor Author

sebsoto commented Nov 25, 2024

/cherrypick release-4.16 release-4.15 release-4.14 release-4.13 release-4.12

@sebsoto
Copy link
Contributor Author

sebsoto commented Nov 25, 2024

/cherry-pick release-4.16 release-4.15 release-4.14 release-4.13 release-4.12

@openshift-cherrypick-robot

@sebsoto: new pull request created: #2556

In response to this:

/cherrypick release-4.16 release-4.15 release-4.14 release-4.13 release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@sebsoto: new pull request could not be created: failed to create pull request against openshift/windows-machine-config-operator#release-4.16 from head openshift-cherrypick-robot:cherry-pick-2546-to-release-4.16: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-2546-to-release-4.16."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherry-pick release-4.16 release-4.15 release-4.14 release-4.13 release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sebsoto
Copy link
Contributor Author

sebsoto commented Nov 25, 2024

/cherry-pick release-4.15

@sebsoto
Copy link
Contributor Author

sebsoto commented Nov 25, 2024

/cherry-pick release-4.14

@sebsoto
Copy link
Contributor Author

sebsoto commented Nov 25, 2024

/cherry-pick release-4.13

@sebsoto
Copy link
Contributor Author

sebsoto commented Nov 25, 2024

/cherry-pick release-4.12

@openshift-cherrypick-robot

@sebsoto: new pull request created: #2557

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@sebsoto: new pull request created: #2558

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@sebsoto: new pull request created: #2559

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@sebsoto: new pull request created: #2560

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants