OCM-13259 | ci: Support hosted-cp shared-vpc profile for rosacli ci

[yuwang-RH]

OCM-13259 | ci: Support hosted-cp shared-vpc profile for rosacli ci

logs on local: https://privatebin.corp.redhat.com/?1314980f61605055#8vXoQWz7Q4HJMcEhyg7BvyrzeDQYxf8nJc8KPRU4PvHF

[yuwang-RH]

@jerichokeyne @hunterkepley @den-rgb Could you help review this PR?

[hunterkepley]

Hey, is go mod vendor required here? Just making sure

Looks like the linter found a few lines which are too long, should be easy to fix

Reviewing the non-vendor code now

[hunterkepley]

overall LGTM besides my question about go mod vendor

[yuwang-RH]

@hunterkepley The linter issue has been fixed with my latest commit. About the vendor change, they are from the golang mod as "github.com/openshift-online/ocm-common v0.0.16" we used have some packages version update. Could you help review again then needs your lgtm label. Thanks.

[hunterkepley]

looks like the hosted-cp flag may be missing from cluster creation based on the failing test

once that's fixed i will set to auto merge

[yuwang-RH]

@hunterkepley The failed test is in presubmit pr job which is not related to the new added function in that PR. The failed job is e2e-presubmits-pr-rosa-sts-advanced , a sts advanced cluster, not a hosted-cp cluster
The presubmit job was designed to try to find day-2 issues on all cluster profiles including the new added. Every new PR will trigger some presubmit jobs in cases of any regression issue involved. I will skip that failed job to merge this PR and will fix the issue of the e2e-presubmits-pr-rosa-sts-advanced later.

[yuwang-RH]

/override ci/prow/e2e-presubmits-pr-rosa-sts-advanced

[openshift-ci]

@yuwang-RH: Overrode contexts on behalf of yuwang-RH: ci/prow/e2e-presubmits-pr-rosa-sts-advanced

In response to this:

/override ci/prow/e2e-presubmits-pr-rosa-sts-advanced

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.11%. Comparing base (06c25f5) to head (e89cac8).
Report is 4 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2740   +/-   ##
=======================================
  Coverage   29.11%   29.11%           
=======================================
  Files         185      185           
  Lines       25805    25805           
=======================================
  Hits         7513     7513           
  Misses      17693    17693           
  Partials      599      599           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hunterkepley]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hunterkepley, yuwang-RH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hunterkepley,yuwang-RH]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@yuwang-RH: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.