Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openshift/os: start building node image #59490

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Dec 4, 2024

As part of openshift/enhancements#1637, we want to start building the node image as a layered build on top of an RHCOS base image.

For now, don't promote this image. In the future, when we're ready to switch CI over, it'll take the place of rhel-coreos.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 4, 2024
Copy link
Contributor

openshift-ci bot commented Dec 4, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jlebon
Copy link
Member Author

jlebon commented Dec 4, 2024

/pj-rehearse pull-ci-openshift-os-master-images

@openshift-ci-robot
Copy link
Contributor

@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jlebon
Copy link
Member Author

jlebon commented Dec 4, 2024

/pj-rehearse pull-ci-openshift-os-master-images

@openshift-ci-robot
Copy link
Contributor

@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jlebon jlebon force-pushed the pr/build-node-image branch from 376d454 to 7e858aa Compare December 4, 2024 13:58
@jlebon
Copy link
Member Author

jlebon commented Dec 4, 2024

/pj-rehearse pull-ci-openshift-os-master-images

@openshift-ci-robot
Copy link
Contributor

@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jlebon jlebon force-pushed the pr/build-node-image branch from 7e858aa to ed6c991 Compare December 5, 2024 00:55
@jlebon
Copy link
Member Author

jlebon commented Dec 5, 2024

/pj-rehearse pull-ci-openshift-os-master-images

@openshift-ci-robot
Copy link
Contributor

@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jlebon jlebon force-pushed the pr/build-node-image branch from ed6c991 to a9bd3e5 Compare December 11, 2024 14:43
@jlebon
Copy link
Member Author

jlebon commented Dec 11, 2024

/pj-rehearse pull-ci-openshift-os-master-images

@openshift-ci-robot
Copy link
Contributor

@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2024
@jlebon
Copy link
Member Author

jlebon commented Dec 11, 2024

/pj-rehearse pull-ci-openshift-os-master-images

@openshift-ci-robot
Copy link
Contributor

@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jlebon
Copy link
Member Author

jlebon commented Dec 11, 2024

/pj-rehearse pull-ci-openshift-os-master-images

@openshift-ci-robot
Copy link
Contributor

@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jlebon
Copy link
Member Author

jlebon commented Dec 11, 2024

/pj-rehearse pull-ci-openshift-os-master-images

@openshift-ci-robot
Copy link
Contributor

@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jlebon
Copy link
Member Author

jlebon commented Dec 11, 2024

/pj-rehearse pull-ci-openshift-os-master-images

@openshift-ci-robot
Copy link
Contributor

@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jlebon
Copy link
Member Author

jlebon commented Dec 12, 2024

/pj-rehearse pull-ci-openshift-os-master-images

@openshift-ci-robot
Copy link
Contributor

@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jlebon
Copy link
Member Author

jlebon commented Dec 12, 2024

/pj-rehearse pull-ci-openshift-os-master-images

@openshift-ci-robot
Copy link
Contributor

@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jlebon
Copy link
Member Author

jlebon commented Dec 12, 2024

/pj-rehearse pull-ci-openshift-os-master-images

@openshift-ci-robot
Copy link
Contributor

@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jlebon
Copy link
Member Author

jlebon commented Dec 19, 2024

@jlebon: all tests passed!

Full PR test history. Your PR dashboard.

Sweet! I'll note here that what just happened is that we built the node image, and then launched the e2e-aws-ovn test which used the node image as its rhel-coreos. (With RHEL 9.6 content.)

@jlebon
Copy link
Member Author

jlebon commented Dec 19, 2024

/pj-rehearse pull-ci-openshift-os-master-images

@openshift-ci-robot
Copy link
Contributor

@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jlebon
Copy link
Member Author

jlebon commented Dec 19, 2024

/pj-rehearse pull-ci-openshift-os-master-images

@openshift-ci-robot
Copy link
Contributor

@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jlebon
Copy link
Member Author

jlebon commented Dec 19, 2024

/pj-rehearse pull-ci-openshift-os-master-images

@openshift-ci-robot
Copy link
Contributor

@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

As part of openshift/enhancements#1637, we want
to start building the node image as a layered build on top of an RHCOS
base image.

For now, don't promote this image. In the future, when we're ready to
switch CI over, it'll take the place of `rhel-coreos`.
Now that we're building the node image in CI, we can run cluster tests
with it. Let's start simple for now with just the standard e2e-aws test.
Note that it doesn't run by default. This means that we can request it
on specific PRs only using `/test`.
@jlebon jlebon force-pushed the pr/build-node-image branch from c8fd2e9 to eeb0002 Compare December 19, 2024 17:25
@jlebon jlebon marked this pull request as ready for review December 19, 2024 17:25
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 19, 2024
@jlebon
Copy link
Member Author

jlebon commented Dec 19, 2024

OK, this is ready now but requires openshift/os#1702.

The second commit hooks up e2e-aws to openshift/os.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jlebon: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-os-master-e2e-aws openshift/os presubmit Presubmit changed
pull-ci-openshift-os-master-images openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-master-rhcos-9-build-test-metal openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-master-rhcos-9-build-test-qemu openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-master-rhcos-96-build-test-metal openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-master-rhcos-96-build-test-qemu openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-master-scos-10-build-test-metal openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-master-scos-10-build-test-qemu openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-master-scos-9-build-test-metal openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-master-scos-9-build-test-qemu openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-master-validate openshift/os presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

items:
- key: credentials
path: credentials
secretName: boskos-credentials
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dumb question - what is boskos?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure TBH. This file was generated by running make update to render the config into jobs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the CI leasing system that prevents us from exhausting finite resources. It can be simple tokens representing the average cluster aggregate resource usage or in some scenarios it's used to manage pools of public IPs, etc.

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trivial LGTM

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024
Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlebon
Copy link
Member Author

jlebon commented Dec 19, 2024

openshift/os#1702 has now merged, so we can now do a final test with it in place:

/pj-rehearse pull-ci-openshift-os-master-images

@openshift-ci-robot
Copy link
Contributor

@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jlebon
Copy link
Member Author

jlebon commented Dec 19, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 19, 2024
Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

@jlebon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit fa2628d into openshift:master Dec 19, 2024
16 checks passed
yingzhanredhat pushed a commit to yingzhanredhat/release that referenced this pull request Dec 24, 2024
* openshift/os: start building node image

As part of openshift/enhancements#1637, we want
to start building the node image as a layered build on top of an RHCOS
base image.

For now, don't promote this image. In the future, when we're ready to
switch CI over, it'll take the place of `rhel-coreos`.

* openshift/os: add an e2e-aws test

Now that we're building the node image in CI, we can run cluster tests
with it. Let's start simple for now with just the standard e2e-aws test.
Note that it doesn't run by default. This means that we can request it
on specific PRs only using `/test`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants