-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openshift/os: start building node image #59490
openshift/os: start building node image #59490
Conversation
Skipping CI for Draft Pull Request. |
/pj-rehearse pull-ci-openshift-os-master-images |
@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-os-master-images |
@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
376d454
to
7e858aa
Compare
/pj-rehearse pull-ci-openshift-os-master-images |
@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
7e858aa
to
ed6c991
Compare
/pj-rehearse pull-ci-openshift-os-master-images |
@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
ed6c991
to
a9bd3e5
Compare
/pj-rehearse pull-ci-openshift-os-master-images |
@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-os-master-images |
@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-os-master-images |
@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-os-master-images |
@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-os-master-images |
@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-os-master-images |
@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-os-master-images |
@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-os-master-images |
@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Sweet! I'll note here that what just happened is that we built the node image, and then launched the e2e-aws-ovn test which used the node image as its |
/pj-rehearse pull-ci-openshift-os-master-images |
@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-os-master-images |
@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-os-master-images |
@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
As part of openshift/enhancements#1637, we want to start building the node image as a layered build on top of an RHCOS base image. For now, don't promote this image. In the future, when we're ready to switch CI over, it'll take the place of `rhel-coreos`.
Now that we're building the node image in CI, we can run cluster tests with it. Let's start simple for now with just the standard e2e-aws test. Note that it doesn't run by default. This means that we can request it on specific PRs only using `/test`.
c8fd2e9
to
eeb0002
Compare
OK, this is ready now but requires openshift/os#1702. The second commit hooks up e2e-aws to openshift/os. |
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
items: | ||
- key: credentials | ||
path: credentials | ||
secretName: boskos-credentials |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dumb question - what is boskos?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure TBH. This file was generated by running make update
to render the config into jobs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the CI leasing system that prevents us from exhausting finite resources. It can be simple tokens representing the average cluster aggregate resource usage or in some scenarios it's used to manage pools of public IPs, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trivial LGTM
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustymabe, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift/os#1702 has now merged, so we can now do a final test with it in place: /pj-rehearse pull-ci-openshift-os-master-images |
@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse ack |
@jlebon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@jlebon: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
* openshift/os: start building node image As part of openshift/enhancements#1637, we want to start building the node image as a layered build on top of an RHCOS base image. For now, don't promote this image. In the future, when we're ready to switch CI over, it'll take the place of `rhel-coreos`. * openshift/os: add an e2e-aws test Now that we're building the node image in CI, we can run cluster tests with it. Let's start simple for now with just the standard e2e-aws test. Note that it doesn't run by default. This means that we can request it on specific PRs only using `/test`.
As part of openshift/enhancements#1637, we want to start building the node image as a layered build on top of an RHCOS base image.
For now, don't promote this image. In the future, when we're ready to switch CI over, it'll take the place of
rhel-coreos
.