Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added NROP upgrade test #58457

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added NROP upgrade test #58457

wants to merge 1 commit into from
+174 −0

Conversation

rbaturov
Copy link
Contributor

@rbaturov rbaturov commented Nov 4, 2024 •
edited
Loading

@openshift-ci-robot
Copy link
Contributor

@rbaturov, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load ci-operator configuration from release repo: invalid ci-operator config: configuration has 2 errors:

 * tests[5].test[0]: `from` or `from_image` is required
 * 'tests[5].test[0].resources' should have at least one request or limit
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@rbaturov rbaturov changed the title Added NROP upgrade test WIP: Added NROP upgrade test Nov 4, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2024
@openshift-ci-robot
Copy link
Contributor

@rbaturov, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load ci-operator configuration from release repo: invalid ci-operator config: invalid configuration: 'tests[5].test[0].resources' should have at least one request or limit
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@rbaturov
Copy link
Contributor Author

rbaturov commented Nov 4, 2024

/retest

@rbaturov
Copy link
Contributor Author

rbaturov commented Nov 4, 2024

/retest

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 4, 2024
@rbaturov
Copy link
Contributor Author

rbaturov commented Nov 4, 2024

/retest

@openshift-ci-robot
Copy link
Contributor

@rbaturov, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load ci-operator configuration from release repo: invalid ci-operator config: invalid configuration: tests[5].cluster_claim.owner cannot be empty when cluster_claim is not nil
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@rbaturov rbaturov force-pushed the nrop-upgrade-lane branch 2 times, most recently from 779c883 to 9dbc2f0 Compare November 4, 2024 13:37
@rbaturov
Copy link
Contributor Author

rbaturov commented Nov 4, 2024

/retest

@rbaturov
Copy link
Contributor Author

rbaturov commented Nov 4, 2024

/retest

1 similar comment
@rbaturov
Copy link
Contributor Author

rbaturov commented Nov 4, 2024

/retest

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 4, 2024
@rbaturov
Copy link
Contributor Author

rbaturov commented Nov 4, 2024

/retest

@rbaturov
Copy link
Contributor Author

rbaturov commented Nov 4, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@rbaturov: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rbaturov
Copy link
Contributor Author

rbaturov commented Nov 4, 2024

/retest

@rbaturov
Copy link
Contributor Author

rbaturov commented Nov 4, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@rbaturov: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rbaturov
Copy link
Contributor Author

rbaturov commented Nov 5, 2024

/retest

@openshift-ci-robot
Copy link
Contributor

@rbaturov: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rbaturov rbaturov force-pushed the nrop-upgrade-lane branch 2 times, most recently from ca18ffe to e1170f1 Compare November 13, 2024 15:26
@rbaturov
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-kni-numaresources-operator-main-e2e-in-cluster-build

@openshift-ci-robot
Copy link
Contributor

@rbaturov: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rbaturov
Copy link
Contributor Author

/retest-required

@rbaturov
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-kni-numaresources-operator-main-e2e-in-cluster-build

@openshift-ci-robot
Copy link
Contributor

@rbaturov: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rbaturov
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-kni-numaresources-operator-main-e2e-in-cluster-build

@openshift-ci-robot
Copy link
Contributor

@rbaturov: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 13, 2024 •
edited
Loading

@rbaturov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift-kni/numaresources-operator/release-4.17/ci-install-e2e 2f7ea70 link unknown /pj-rehearse pull-ci-openshift-kni-numaresources-operator-release-4.17-ci-install-e2e
ci/rehearse/openshift-kni/numaresources-operator/release-4.17/e2e-in-cluster-build 2f7ea70 link unknown /pj-rehearse pull-ci-openshift-kni-numaresources-operator-release-4.17-e2e-in-cluster-build
ci/rehearse/openshift-kni/numaresources-operator/main/4.17-to-4.18-upgrade-test 6dc9142 link unknown /pj-rehearse pull-ci-openshift-kni-numaresources-operator-main-4.17-to-4.18-upgrade-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rbaturov rbaturov force-pushed the nrop-upgrade-lane branch 2 times, most recently from b98353d to 3ab4e5d Compare November 14, 2024 12:43
@rbaturov
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-kni-numaresources-operator-main-e2e-operator-upgrade

@openshift-ci-robot
Copy link
Contributor

@rbaturov: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rbaturov
Once this PR has been reviewed and has the lgtm label, please assign schseba, yanirq for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rbaturov
Added NROP upgrade test
6c932e6 
Signed-off-by: Ronny Baturov <[email protected]>
@rbaturov
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-kni-numaresources-operator-main-e2e-operator-upgrade

@openshift-ci-robot
Copy link
Contributor

@rbaturov: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@rbaturov: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kni-numaresources-operator-main-e2e-operator-upgrade openshift-kni/numaresources-operator presubmit Presubmit changed
pull-ci-openshift-kni-numaresources-operator-main-ci-e2e openshift-kni/numaresources-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-numaresources-operator-main-ci-e2e-install-hypershift openshift-kni/numaresources-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-numaresources-operator-main-ci-index openshift-kni/numaresources-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-numaresources-operator-main-ci-install-e2e openshift-kni/numaresources-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-numaresources-operator-main-ci-unit openshift-kni/numaresources-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-numaresources-operator-main-images openshift-kni/numaresources-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-numaresources-operator-main-security openshift-kni/numaresources-operator presubmit Ci-operator config changed
periodic-ci-openshift-kni-numaresources-operator-main-ci-must-gather-e2e N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@Tal-or Tal-or mentioned this pull request Nov 17, 2024
Open
@rbaturov rbaturov changed the title WIP: Added NROP upgrade test Added NROP upgrade test Nov 18, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2024
@rbaturov
Copy link
Contributor Author

/hold
Depends on:
openshift-kni/numaresources-operator#1073

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tal-or Tal-or Tal-or left review comments

@ffromani ffromani Awaiting requested review from ffromani

@swatisehgal swatisehgal Awaiting requested review from swatisehgal

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rbaturov @openshift-ci-robot @Tal-or @openshift-merge-robot