Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

steps/gcp-upi: Use coreos print-stream-json if available #23392

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

jstuever
Copy link
Contributor

@jstuever jstuever commented Nov 8, 2021

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2021
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2021
@petr-muller
Copy link
Member

/uncc @droslean @petr-muller
/cc @patrickdillon

@openshift-ci openshift-ci bot requested review from patrickdillon and removed request for petr-muller and droslean November 8, 2021 18:47
@jstuever jstuever changed the title WIP steps/gcp-upi: Use coreos print-stream-json if available steps/gcp-upi: Use coreos print-stream-json if available Nov 8, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 8, 2021

@jstuever: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/installer/release-4.9/e2e-gcp-upi-xpn 4ef39ab link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-verification-tests-master-ocp-4.9-e2e-gcp-cucushift-upi 4ef39ab link unknown /test pj-rehearse
ci/prow/pj-rehearse 4ef39ab link false /test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jstuever
Copy link
Contributor Author

jstuever commented Nov 8, 2021

/cc @staebler

@openshift-ci openshift-ci bot requested a review from staebler November 8, 2021 21:51
@patrickdillon
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5951038 into openshift:master Nov 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 9, 2021

@jstuever: Updated the step-registry configmap in namespace ci at cluster app.ci using the following files:

  • key upi-install-gcp-commands.sh using file ci-operator/step-registry/upi/install/gcp/upi-install-gcp-commands.sh

In response to this:

Part of openshift/enhancements#679

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jstuever jstuever deleted the rhcosgcpupi branch February 11, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants