Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.15] OCPBUGS-47799: Let OVN-northd bind remote ports #2407

Merged
merged 1 commit into from
Jan 16, 2025
Merged

[release-4.15] OCPBUGS-47799: Let OVN-northd bind remote ports #2407

merged 1 commit into from
Jan 16, 2025

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2406

/assign trozet

@numansiddique
interconenct: Ask ovn-northd to bind the remote ports.
defd136 
Presently for each remote node, ovnkube after creating the
remote port in the OVN Northbound db transit switch, binds the port to
the remote chassis in the Southbound database.  In order to do this,
we have to wait for the remote logical ports (for each of the
remote zone nodes) to appear in the OVN Southbound database.
This can lead to race conditions.  Instead ask ovn-northd to
bind to the remote chassis.  OVN after this commit [1] already
supports this.  We just need to set the requested-chassis
option in the logical port.

[1] - ovn-org/ovn@170d3e5

Jira: https://issues.redhat.com/browse/OCPBUGS-42616

Signed-off-by: Numan Siddique <[email protected]>
(cherry picked from commit e4f360c)
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 6, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-47634 has been cloned as Jira Issue OCPBUGS-47799. Will retitle bug to link to clone.
/retitle [release-4.15] OCPBUGS-47799: Let OVN-northd bind remote ports

In response to this:

This is an automated cherry-pick of #2406

/assign trozet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.15] OCPBUGS-47634: Let OVN-northd bind remote ports [release-4.15] OCPBUGS-47799: Let OVN-northd bind remote ports Jan 6, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 6, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-47799, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-47634 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-47634 targets the "4.16.z" version, which is one of the valid target versions: 4.16.0, 4.16.z
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #2406

/assign trozet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@trozet
Copy link
Contributor

trozet commented Jan 7, 2025

/retest

3 similar comments
@trozet
Copy link
Contributor

trozet commented Jan 7, 2025

/retest

@trozet
Copy link
Contributor

trozet commented Jan 8, 2025

/retest

@trozet
Copy link
Contributor

trozet commented Jan 8, 2025

/retest

@trozet
Copy link
Contributor

trozet commented Jan 10, 2025

/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 10, 2025
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2025
@trozet
Copy link
Contributor

trozet commented Jan 10, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@trozet
Copy link
Contributor

trozet commented Jan 10, 2025

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link
Author

@trozet: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@asood-rh
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 13, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD daaf1b8 and 2 for PR HEAD defd136 in total

6 similar comments
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD daaf1b8 and 2 for PR HEAD defd136 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD daaf1b8 and 2 for PR HEAD defd136 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD daaf1b8 and 2 for PR HEAD defd136 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD daaf1b8 and 2 for PR HEAD defd136 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD daaf1b8 and 2 for PR HEAD defd136 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD daaf1b8 and 2 for PR HEAD defd136 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 16, 2025 •
edited
Loading

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security defd136 link false /test security
ci/prow/e2e-aws-ovn-kubevirt defd136 link false /test e2e-aws-ovn-kubevirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD daaf1b8 and 2 for PR HEAD defd136 in total

@openshift-merge-bot openshift-merge-bot bot merged commit cc1522a into openshift:release-4.15 Jan 16, 2025
29 of 31 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-47799: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-47799 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #2406

/assign trozet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link
Author

@trozet: new pull request created: #2418

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 16, 2025
Open
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ovn-kubernetes-base
This PR has been included in build ose-ovn-kubernetes-base-container-v4.15.0-202501162106.p0.gcc1522a.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ovn-kubernetes-microshift
This PR has been included in build ovn-kubernetes-microshift-container-v4.15.0-202501162106.p0.gcc1522a.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-ovn-kubernetes
This PR has been included in build ose-ovn-kubernetes-container-v4.15.0-202501162106.p0.gcc1522a.assembly.stream.el9.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2025-01-16-234327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trozet trozet Awaiting requested review from trozet trozet is a code owner

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@jcaamano jcaamano Awaiting requested review from jcaamano

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@trozet trozet

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@yingwang-0320 yingwang-0320

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.