[DNM] test ovn-kubernetes/ovn-kubernetes#4884 #2405
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of today the NetworkReady condition indicated a NAD has been created. And not necessarily that the underlying network is ready to work with, because it require other internal components to act (e.g.: set ovs ports, ovn flows, etc..). Rename the NetworkReady condition type to NetworkCreated so it describe better what it indicates. This change enable introducing alternative "NetworkReady" condition that provider actual indication a UDN network is ready, and that other internal component acted successfully. Signed-off-by: Or Mergi <[email protected]>
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ormergi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test ovn-kubernetes/ovn-kubernetes#4884
📑 Description
Fixes #
Additional Information for reviewers
✅ Checks
How to verify it