Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.17] SDN-4919,OCPBUGS-39200: 4.18 merge - 5th Sept #2291

Open
wants to merge 52 commits into
base: release-4.17
Choose a base branch
from

Commits on Aug 9, 2024

  1. Change pod and join subnet used with net-attach-def in unit tests

    This is to change POD and join subnet used with couple of net-attach-def
    in unit tests to satisfy newly introduced subnet overlap check with
    ClusterNetwork, ServiceNetwork, join switch and masquerade CIDR.
    
    Signed-off-by: Arnab Ghosh <[email protected]>
    arghosh93 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    05ccb99 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. docs, api-reference: Add UDN CRD API doc

    UDN API referance generated using the following command:
      crd-ref-docs --source-path ./go-controller/pkg/crd/userdefinednetwork --config=crd-docs-config.yaml --renderer=markdown --output-path=./docs/api-reference/userdefinednetwork-api-spec.md
    
    Signed-off-by: Or Mergi <[email protected]>
    ormergi committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    28f70c4 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Dockerfile: Bump OVS to 3.4.0-1

    The new OVS version is used by the OVN observability.
    
    Signed-off-by: Nadia Pinaeva <[email protected]>
    npinaeva committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    7cc6368 View commit details
    Browse the repository at this point in the history
  2. Dockerfile: Bump OVS to 3.4.0-1 for OKD.

    Signed-off-by: Nadia Pinaeva <[email protected]>
    npinaeva committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    2e7da21 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. UDN:LGW: Add MASQUERADE IPT Rule

    Signed-off-by: Surya Seetharaman <[email protected]>
    tssurya committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    7ca7cec View commit details
    Browse the repository at this point in the history
  2. Merge pull request #4552 from tssurya/udn-add-iptrules

    UDN: Add `MASQUERADE` IPTable Rules
    trozet authored Aug 28, 2024
    Configuration menu
    Copy the full SHA
    da1386b View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. UDN: allow multiple conditions of different types to co-exist in the

    status.
    
    Signed-off-by: Nadia Pinaeva <[email protected]>
    npinaeva committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    a95e101 View commit details
    Browse the repository at this point in the history
  2. UDN: Add rp_filter loose mode for management port

    Signed-off-by: Surya Seetharaman <[email protected]>
    tssurya committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    c94b937 View commit details
    Browse the repository at this point in the history
  3. Merge pull request openshift#2273 from npinaeva/ovs-3.4

    OCPBUGS-38270: Dockerfile: Bump OVS to 3.4.0-1
    openshift-merge-bot[bot] authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    90d145b View commit details
    Browse the repository at this point in the history
  4. Merge pull request #4664 from npinaeva/udn-status

    UDN: allow multiple conditions from different fieldManagers to co-exist in the status.
    tssurya authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    28b1db4 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #4553 from tssurya/udn-add-rp-filter-loose-mode-ma…

    …nagement-port
    
    UDN: Add RPFilter Loose Mode for management port
    trozet authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    15c5621 View commit details
    Browse the repository at this point in the history
  6. Move mirrored endpointslice constants to types pkg

    Signed-off-by: Riccardo Ravaioli <[email protected]>
    ricky-rav committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    a4fbb99 View commit details
    Browse the repository at this point in the history
  7. Fixes remote node checks to be network aware

    Everytime a UDN was created, we were adding the all remote nodes for
    every network all over again, including the default network. This makes
    the checks on the annotations network aware.
    
    Signed-off-by: Tim Rozet <[email protected]>
    trozet committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    7310251 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Services controller: add support for UDNs

    Services controller:
    - move it to base network controller
    - start one services controller per primary network
    - set up filter in the informer so that only endpointslices for the given network are considered
    - pass switch and router names according to the network for a given node.
    
    Move getActiveNetworkForNamespace to CommonNetworkControllerInfo, because the services controller only has access to CommonNetworkControllerInfo at initialization and needs to run getActiveNetworkForNamespace.
    
    Make LBs and LB groups network scoped
    
    Add network name & role to OVN external IDs. In a few places in the code we retrieve all logical switches, routers and load balancers to initialize the services controller or to delete stale entries. With one services controller per network, the OVN lookup must only return OVN elements in the network we're interested in. This is achieved by adding the network name and network role (default, primary, secondary) to the ExternalIDs field of logical switches, routers and load balancers.
    
    Signed-off-by: Riccardo Ravaioli <[email protected]>
    ricky-rav committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    4cf0a2e View commit details
    Browse the repository at this point in the history
  2. Services controller: add network name to logs

    Signed-off-by: Riccardo Ravaioli <[email protected]>
    ricky-rav committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    d2fd6a9 View commit details
    Browse the repository at this point in the history
  3. Services controller: update ExternalIDs in existing unit tests

    Signed-off-by: Riccardo Ravaioli <[email protected]>
    ricky-rav committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    1aaa219 View commit details
    Browse the repository at this point in the history
  4. Services controller: add unit tests for UDNs

    The existing unit tests for services in services_controller_test are now run for UDN as well.
    
    At the same time, a cleanup of unit tests was needed, especially since there was a lot of repetition in the surrounding code, also with respect to global and test-specific variables between services_controller_test.go and lb_config_test.go
    
    Finally, Test_ETPCluster_NodePort_Service_WithMultipleIPAddresses follows the exact same logic found in TestSyncServices, so let's move it there
    
    Signed-off-by: Riccardo Ravaioli <[email protected]>
    ricky-rav committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    a39da39 View commit details
    Browse the repository at this point in the history
  5. Allow execution of other network segmentation with WHAT parameter

    Allows the execution of the network segmentation tests that are in network_segmentation_*.go (e.g. services, endpoint slice mirrorring). For instance:
    
    make control-plane WHAT="Network Segmentation: services"
    
    Signed-off-by: Riccardo Ravaioli <[email protected]>
    ricky-rav committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    3d05dec View commit details
    Browse the repository at this point in the history
  6. E2E tests for services on UDN

    The test creates a client and nodeport service in a UDN backed by one pod and similarly
    a nodeport service and a client in the default network.
    We verify that:
    - UDN client --> UDN service, with backend pod and client running on the same node, is possible through:
      + clusterIP
      + nodeIP:nodePort, where we only target the node where the client runs (*)
    
    - UDN client --> UDN service, with backend pod and client running on different nodes, is possible through:
      + clusterIP
      + nodeIP:nodePort, where we only target the node where the client runs (*)
    
    - default-network client --> UDN service is NOT possible through:
      + clusterIP
      + nodeIP:nodePort, where we only target the node where the client runs (*)
    
    -  UDN service --> default-network client is NOT possible through:
      + clusterIP
      + nodeIP:nodePort, where we only target the node where the client runs (*)
    
    (*) TODO connect to other nodes too once ovnkube-node fully supports UDN
    
    TODO: use the same logic as in network_segmentation.go
    
    Signed-off-by: Riccardo Ravaioli <[email protected]>
    ricky-rav committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    3d0665b View commit details
    Browse the repository at this point in the history
  7. Use faked iptables in UDN gateway tests

    Signed-off-by: Jaime Caamaño Ruiz <[email protected]>
    jcaamano committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    c3b0419 View commit details
    Browse the repository at this point in the history
  8. Update Dockerfile.fedora to use pre-released 24.09 ovn rpm.

    Remove tabs.
    
    Signed-off-by: Nadia Pinaeva <[email protected]>
    npinaeva committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    aac171c View commit details
    Browse the repository at this point in the history
  9. Merge pull request #4555 from ricky-rav/UDNservicesL3_ontoptest2

    UDN L3 support for services
    trozet authored Aug 30, 2024
    Configuration menu
    Copy the full SHA
    6e5d943 View commit details
    Browse the repository at this point in the history
  10. Merge pull request #4675 from jcaamano/fake-iptables

    Use faked iptables in UDN gateway tests
    tssurya authored Aug 30, 2024
    Configuration menu
    Copy the full SHA
    5a10234 View commit details
    Browse the repository at this point in the history
  11. Merge pull request #4658 from npinaeva/bump-ovn

    Update Dockerfile.fedora to use pre-released 24.09 ovn rpm.
    trozet authored Aug 30, 2024
    Configuration menu
    Copy the full SHA
    9989e39 View commit details
    Browse the repository at this point in the history
  12. Merge pull request #4672 from trozet/fix_remote_node_add

    Fixes remote node checks to be network aware
    trozet authored Aug 30, 2024
    Configuration menu
    Copy the full SHA
    2f49160 View commit details
    Browse the repository at this point in the history
  13. udn, e2e: Don't use secondary node IPs for node port test.

    Signed-off-by: Dumitru Ceara <[email protected]>
    dceara committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    9f809fe View commit details
    Browse the repository at this point in the history
  14. zone_ic_handler: Make sure routes to other zones are added for UDN.

    UDN layer 3 networks also have a join switch and gateway router.
    
    Signed-off-by: Dumitru Ceara <[email protected]>
    dceara committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    816835f View commit details
    Browse the repository at this point in the history
  15. nodePortWatcher: Only build svc cookie if needed.

    In the "delete" case we don't need the cookie, move the code that builds
    the cookie after the section that checks and takes care of deletes.
    
    Signed-off-by: Dumitru Ceara <[email protected]>
    dceara committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    3d95d47 View commit details
    Browse the repository at this point in the history
  16. node, udn: Add function to get active bridge net config.

    Signed-off-by: Dumitru Ceara <[email protected]>
    dceara committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    03b442c View commit details
    Browse the repository at this point in the history
  17. node, udn: Allow nodePortWatcher/nodePortWatcherIptables to query the…

    … namespace active network
    
    Signed-off-by: Dumitru Ceara <[email protected]>
    dceara committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    f31b8f4 View commit details
    Browse the repository at this point in the history
  18. Add udn.GetUDNGatewayMasqueradeIPs utils

    Signed-off-by: Surya Seetharaman <[email protected]>
    tssurya committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    fd9ee80 View commit details
    Browse the repository at this point in the history
  19. Add per-pod SNAT for UDNs

    Signed-off-by: Surya Seetharaman <[email protected]>
    tssurya committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    c31cf5d View commit details
    Browse the repository at this point in the history
  20. gateway, node, udn: Pass netInfo down to the node port watchers.

    Signed-off-by: Dumitru Ceara <[email protected]>
    dceara committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    aa321f7 View commit details
    Browse the repository at this point in the history
  21. Delete per-pod SNAT for UDNs

    Signed-off-by: Surya Seetharaman <[email protected]>
    tssurya committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    9945dec View commit details
    Browse the repository at this point in the history
  22. UDN: Lanes should run with ds flag set

    Signed-off-by: Surya Seetharaman <[email protected]>
    tssurya committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    dc13db7 View commit details
    Browse the repository at this point in the history
  23. udn, node: Make br-ex flows network aware.

    For each service change node port related flows to redirect traffic to
    the OVN patch port that connects br-ex to the UDN's logical topology.
    
    Signed-off-by: Dumitru Ceara <[email protected]>
    dceara committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    fe8e6d1 View commit details
    Browse the repository at this point in the history
  24. udn, e2e: Add node port services e2e test for UDN.

    Signed-off-by: Dumitru Ceara <[email protected]>
    dceara committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    d396c12 View commit details
    Browse the repository at this point in the history
  25. Merge pull request #4648 from dceara/net-seg-ingress-br-ex

    UDN: SGW: L2/L3 Add support for external -> service traffic.
    trozet authored Aug 30, 2024
    Configuration menu
    Copy the full SHA
    2260d10 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2024

  1. Merge pull request #4595 from ormergi/network-api-doc

    docs, api-reference: Add doc for UDN API
    tssurya authored Aug 31, 2024
    Configuration menu
    Copy the full SHA
    d132a39 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. Merge pull request #4669 from tssurya/udn-fix-per-pod-snating

    UDN: Fix per pod SNATing
    tssurya authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    50a9edf View commit details
    Browse the repository at this point in the history
  2. Add subnet overlap check for POD and join subnets in net-attach-def

    This is to validate whether POD and join subnet mentioned in a
    net-attach-def with topology "layer2" and "layer3" does not overlap
    with ClusterSubnets, ServiceCIDRs, join subnet and masquerade subnet.
    It also considers excluded subnets mentioned in a net-attach-def.
    
    Signed-off-by: Arnab Ghosh <[email protected]>
    arghosh93 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    5115b72 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. EIP IPv6 e2es: enable for control plane tests

    Signed-off-by: Martin Kennelly <[email protected]>
    martinkennelly authored and jcaamano committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    51b6cf5 View commit details
    Browse the repository at this point in the history
  2. EIP e2es - healthcheck: drop packets for IPv6 to cause node unavailab…

    …ility
    
    Signed-off-by: Martin Kennelly <[email protected]>
    martinkennelly authored and jcaamano committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    b888c21 View commit details
    Browse the repository at this point in the history
  3. EIP e2e: fix IPv6 e2e VRF test

    IPv6 link addresses behave differently than IPv4
    addresses when a link is enslaved to a VRF device.
    For IPv4, addresses assigned to the link are preserved
    but for IPv6, non link local addresses are removed.
    Therefore when a link is enslaved, this commit manually
    readds the global IPv6 address.
    
    Signed-off-by: Martin Kennelly <[email protected]>
    martinkennelly authored and jcaamano committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    54e5a87 View commit details
    Browse the repository at this point in the history
  4. Fix E2E util for dropping traffic on a particular port

    Previous op was invalid.
    
    Signed-off-by: Martin Kennelly <[email protected]>
    martinkennelly authored and jcaamano committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    22727db View commit details
    Browse the repository at this point in the history
  5. Merge pull request #4604 from arghosh93/SDN-5138

    Add subnet overlap check for POD and join subnets in net-attach-def
    tssurya authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    834fd00 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Merge pull request openshift#2276 from martinkennelly/merge-28-aug

    SDN-4930,OCPBUGS-38949: Downstream Merge 28th August
    openshift-merge-bot[bot] authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    152f838 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3764092 View commit details
    Browse the repository at this point in the history
  3. OCPHACK: Rename unit test file for downstream-only tests

    Rename load_balancer_ocphack_test.go as lb_config_ocphack_test.go
    
    Signed-off-by: Riccardo Ravaioli <[email protected]>
    ricky-rav authored and martinkennelly committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    0d132d3 View commit details
    Browse the repository at this point in the history
  4. OCPHACK: downstream-only unit tests for services: add UDN support

    Signed-off-by: Riccardo Ravaioli <[email protected]>
    ricky-rav authored and martinkennelly committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    49ddde7 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Merge pull request openshift#2286 from martinkennelly/merge_04_08_24

    OCPBUGS-39157,SDN-4930: Downstream Merge Sept 4th
    openshift-merge-bot[bot] authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    14fb7c4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    129a097 View commit details
    Browse the repository at this point in the history