-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2099811: manifest: bump to openvswitch2.16 #715
Conversation
We want to keep host OVS and container OVS synchronized as much as possible, plus OVS 2.16 is the first release that can take advantage of kernel features like per-cpu dispatch (if the kernel has it). Signed-off-by: Dan Williams <[email protected]>
Seems like a fine change to me; are there any specific requirements on the host OS? i.e. kernel, etc? |
Related: #498 Meanwhile, if you have a checklist somewhere for rebasing Open vSwitch in the SDN container, it might be good to add an item for bumping it here too. /approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm open to making this switch. Ooh: better: I'm open to shifting the switch.
@miabbott no requirements on host OS; RHEL QE tests the versions of OVS that we ship in FDP against various versions of RHEL. If it shows up in FDP releases then we support it. |
@jlebon no checklist other than (a) has it been through normal RHEL FDP QE? and (b) does it pass CI? |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, dcbw, jlebon, miabbott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
One thing I'll note here that's important: CI here isn't going to test this in any meaningful way, i.e. we aren't yet today launching a cluster from this build. Hopefully soon we will be though! |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
I believe the CI failed due to #718 + openshift/release#26305, but I built and tested this locally with success. /override ci/prow/build-test-qemu |
@miabbott: Overrode contexts on behalf of miabbott: ci/prow/build-test-qemu In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dcbw: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@dcbw: All pull requests linked via external trackers have merged: Bugzilla bug 2099811 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We want to keep host OVS and container OVS synchronized as much
as possible, plus OVS 2.16 is the first release that can take
advantage of kernel features like per-cpu dispatch (if the kernel
has it).
@trozet