-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using EOL Fedora container images in older releases #1546
Labels
Comments
jlebon
added a commit
to jlebon/os
that referenced
this issue
Aug 22, 2024
In this stage of the build, we're just using Fedora to generate repodata. Since this is a pretty basic operation, let's just always use the latest Fedora instead of hardcoding a specific version. This ensures that e.g. we're never going to use an EOL Fedora release. This became an issue after 8301c67 ("extensions/Dockerfile: use the FCOS defined fedora.repo to set up container"), which was backported to older RHCOS branches that used EOL Fedora releases. Before, we were using the mirrors, which papered over the fact that the content for EOL releases actually moved to another location. But now that we're using the canonical Fedora server, we're directly exposed to that. Really, we should just stop hardcoding Fedora versions in this repo. We shouldn't be using EOL releases at all as part of our builds or tests. (Obviously a massive offender here is cosa... though that's a discussion of its own.) See also: openshift#1546
This was referenced Aug 22, 2024
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
Denotes an issue or PR has remained open with no activity and has become stale.
label
Oct 14, 2024
/remove-lifecycle stale |
openshift-ci
bot
removed
the
lifecycle/stale
Denotes an issue or PR has remained open with no activity and has become stale.
label
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some of our tests shared with FCOS build containers locally. Once we branch f-c-c for RHCOS, those container references are never updated. Once those Fedora releases go EOL, their content move. And while it should keep working, hiccups do happen in that transition (see e.g. https://pagure.io/fedora-infrastructure/issue/11221 and https://pagure.io/releng/issue/12204).
But anyway, it's also not great to be relying on EOL content in our tests.
My proposal is to modify those tests to use UBI images on RHCOS, c9s images on SCOS, and Fedora images on FCOS.
The text was updated successfully, but these errors were encountered: