tests/kola: use latest fedora:latest on tests that require it #3123
Conversation
both `ntp.chrony.dhcp-propagation` and `podman.rootless-systemd` use the Fedora container to set up the environment for the test. Always use the `fedora:latest` container so we never use EOL Fedora releases in kola tests.
marmijo
force-pushed
the
use-latest-fedora-container
branch
from
29b98ea to
6325585
Compare
|
hmm. I feel like we pin on purpose (since moving tags move at times which could be inopportune for us). Don't we usually bump these when we switch to a new Fedora major? I guess another way to phrase this line of questioning.. what problem are we solving? |
|
@dustymabe See the commit message in openshift/os#1583 for details. But yeah, also not sure about this even though I agree it's a logical follow-up to openshift/os#1583. One difference from that PR though that motivated me there is that in the extensions case, we're doing something trivial with the Fedora image: installing The tests here OTOH are doing more complex things like dnsmasq, httpd, and running systemd as init in the container... which I can definitely imagine breaking. And we don't want e.g. a broken dnsmasq or systemd update in the latest Fedora to suddenly break all our streams. I guess easiest short-term is to add a new I still think the cleanest approach for these tests though is to eventually use content from the same compose we're building from (openshift/os#1546). |
Even there maybe we should be using CentOS or RHEL instead. I could foresee a case where create_repo adopted a new feature or default that older clients couldn't handle.
correct.. or even something as simple as glibc updates in newer Fedora containers not being compatible with older branched OS. I vaguely remember cases where older OS couldn't run newer containers.
👍 |
That actually used to be the case, but we moved to Fedora because of openshift/os#1000. We might be able to revisit this now. (Obviously something we'd need to figure out too for openshift/os#1546.) |
|
I've just realized that we actually have such a potentially breaking change coming in Fedora 41: https://discussion.fedoraproject.org/t/f41-change-proposal-upgrade-systems-to-createrepo-c-1-0-and-change-repositories-metadata-settings/108893 So openshift/os#1583 might be a risk as well. |
Certain kola tests on older RHCOS branches rely on EOL fedora containers to set up and run the test environment. Right now, the older content can be found on the mirrors, but as part of the RHCOS pipeline migration effort to the ITUP cluster, we have to explicitly specify each outbound connection. Add a `fedora-archive.repo` file to be used in these tests so we can always download the older content from: https://dl.fedoraproject.org see: coreos#3123 (comment)
I opened #3128 as a first attempt at that. |
Certain kola tests on older RHCOS branches rely on EOL fedora containers to set up and run the test environment. Right now, the older content can be found on the mirrors, but as part of the RHCOS pipeline migration effort to the ITUP cluster, we have to explicitly specify each outbound connection. Add a `fedora-archive.repo` file to be used in these tests so we can always download the older content from: https://dl.fedoraproject.org see: coreos#3123 (comment)
Certain kola tests on older RHCOS branches rely on EOL fedora containers to set up and run the test environment. Right now, the older content can be found on the mirrors, but as part of the RHCOS pipeline migration effort to the ITUP cluster, we have to explicitly specify each outbound connection. Add a `fedora-archive.repo` file to be used in these tests so we can always download the older content from: https://dl.fedoraproject.org see: #3123 (comment)
|
Closing because it was decided that #3128 would be the solution here |
Both
ntp.chrony.dhcp-propagationandpodman.rootless-systemduse the Fedora container to set up the environment for the test. Always use thefedora:latestcontainer so we never use EOL Fedora releases in kola tests.