Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-17791: opm: always serve pprof endpoints, improve server allocations (#1129) #540

Merged
merged 1 commit into from
Aug 22, 2023
Merged

OCPBUGS-17791: opm: always serve pprof endpoints, improve server allocations (#1129) #540

merged 1 commit into from
Aug 22, 2023

Commits on Aug 14, 2023

  1. opm: always serve pprof endpoints, improve server allocations (#1129) 

    * pkg/cache: use a shared buffer to limit allocations

Previously, new buffers were allocated on each file we read in, which
was unnecessary and wasteful.

Signed-off-by: Steve Kuznetsov <[email protected]>

* cmd/opm: serve pprof endpoints by default

There is no substantial runtime cost to serving pprof endpoints, and
when things hit the fan and we need to investigate performance in situ,
there is no time to restart pods and change flags. Capturing profiles
remains opt-in, since those are costly.

Signed-off-by: Steve Kuznetsov <[email protected]>

---------

Signed-off-by: Steve Kuznetsov <[email protected]>
Upstream-repository: operator-registry
Upstream-commit: 68e13df96590977370ffcd1a8e9ff76e0f2a03f2
Signed-off-by: Steve Kuznetsov <[email protected]>
    @stevekuznetsov
    stevekuznetsov committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    4c80bff View commit details
    Browse the repository at this point in the history