[OCPBUGS-44731]: Add note about service publishing for HCP on BM #86913
Conversation
openshift-ci
bot
added
the
size/XS
|
/lgtm |
lahinson
added
peer-review-needed
skopacz1
added
the
peer-review-in-progress
modules/hcp-bm-hc.adoc
Outdated
| @@ -18,6 +18,8 @@ As you create a hosted cluster, keep the following guidelines in mind: | |||
|
|
|||
| - A hosted cluster cannot be created in the namespace of a {mce-short} managed cluster. | |||
|
|
|||
| - The most common service publishing strategy is to expose services through a load balancer. That strategy is the preferred method for exposing the Kubernetes API server. If you create a hosted cluster by using the web console or by using {rh-rhacm-title}, to set a publishing strategy for a service besides the Kubernetes API server, you must manually specify the `servicePublishingStrategy` in the `HostedCluster` custom resource. | |||
There was a problem hiding this comment.
It's probably fine as is, but it reads a little odd that there's no noun following "the servicePublishingStrategy" based on what i see elsewhere in the docs. Is it possible to add something like "parameter" or "option" there? Up to you
There was a problem hiding this comment.
Good point. I don't think "parameter" or "option" are quite right, so I added "information" as the noun after servicePublishingStrategy.
skopacz1
added
peer-review-done
lahinson
force-pushed
the
ocpbugs-44731-hcp-load-balancer
branch
from
0a2d26b to
10e60b7
Compare
|
New changes are detected. LGTM label has been removed. |
|
@lahinson: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.17 |
|
/cherrypick enterprise-4.18 |
|
@lahinson: new pull request created: #86966 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lahinson: new pull request created: #86967 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s): 4.17+
Issue: https://issues.redhat.com/browse/OCPBUGS-44731
Link to docs preview: https://86913--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hosted_control_planes/hcp-deploy/hcp-deploy-bm.html#hcp-bm-hc_hcp-deploy-bm (see the last bullet point)
QE review:
Additional information: