-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.0 GA OSSM-8673 Pre-migration checklist for product docs #86912
base: service-mesh-docs-main
Are you sure you want to change the base?
3.0 GA OSSM-8673 Pre-migration checklist for product docs #86912
Conversation
🤖 Thu Jan 23 21:11:44 - Prow CI generated the docs preview: |
** [ ] Disable Kiali by setting `spec.addons.kiali.enabled=false``. See "Kiali Operator provided by Red Hat" for instructions installing and configuring {KialiProduct} with {SMProduct} 3.0. | ||
** [ ] Disable Grafana by setting `spec.addons.grafana.enabled=false`. | ||
** [ ] Disable {DTProductName} by setting `spec.tracing.type=None`. See "{DTProductName}" for instructions on configuring {SMProduct} 3.0 with {DTProductName}. | ||
IOR is disabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the last two steps, "IOR is disabled" and "Disable default ingress and egress gateways", we should link to the specific content that describes how to make these changes. That is, Route migration and Gateway Migration
These addons are not supported in {SMProduct} 3.0 and must be disabled before migrating. | ||
|
||
** [ ] Disable network policy management by setting `spec.security.manageNetworkPolicy=false`. If you wish to keep the Network Policies created by the 2.6 ServiceMeshControlPlane, you will need to recreate and manage these manually. | ||
** [ ] Disable Prometheus by setting `spec.addons.prometheus.enabled=false`. See "User workload monitoring" for instructions configuring {SMProduct}h 3.0 with OpenShift Monitoring as a replacement for Prometheus. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Users may want to make this change before migrating to OSSM 3, in which case, we should link to the 2.x documentation for using user-workload monitoring, located here: https://docs.openshift.com/container-platform/4.17/service_mesh/v2x/ossm-observability.html#ossm-integrating-with-user-workload-monitoring_observability.
** [ ] Disable Prometheus by setting `spec.addons.prometheus.enabled=false`. See "User workload monitoring" for instructions configuring {SMProduct}h 3.0 with OpenShift Monitoring as a replacement for Prometheus. | ||
** [ ] Disable Kiali by setting `spec.addons.kiali.enabled=false``. See "Kiali Operator provided by Red Hat" for instructions installing and configuring {KialiProduct} with {SMProduct} 3.0. | ||
** [ ] Disable Grafana by setting `spec.addons.grafana.enabled=false`. | ||
** [ ] Disable {DTProductName} by setting `spec.tracing.type=None`. See "{DTProductName}" for instructions on configuring {SMProduct} 3.0 with {DTProductName}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likewise, users may wish to make this migration before moving to 3.0, which can be done by following these instructions: https://docs.openshift.com/container-platform/4.17/service_mesh/v2x/ossm-observability.html#ossm-overview-distr-tracing_observability
4b7c29a
to
b894820
Compare
1eb3f27
to
ce99022
Compare
//Applicable PR: https://github.com/openshift/openshift-docs/pull/86917 | ||
//will contain both mulitenant and cert-manager procedures | ||
|
||
.Next steps for multitenant deployments with cert-manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this affects how you structure things or not but the migration guide for cert-manager is essentially the same for both MultiTenant
and ClusterWide
. The only difference is that some MultiTenant
deployments might be using a specific field/feature of cert-manager in which case they will need to handle it differently than ClusterWide
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm remembering now we discussed that some duplication was better than having the guide more scattered
*2*. Ensure the `bookinfo` application is still working correctly. | ||
|
||
```sh | ||
oc exec -it -n bookinfo deployments/productpage-v1 -c istio-proxy -- curl localhost:9080/productpage | ||
``` | ||
|
||
Example response: | ||
|
||
```html | ||
... | ||
<p>Absolutely fun and entertaining. The play lacks thematic depth when compared to other plays by Shakespeare.</p> | ||
<small>Reviewer2</small> | ||
|
||
|
||
<font color="black"> | ||
<!-- full stars: --> | ||
|
||
<span class="glyphicon glyphicon-star"></span> | ||
|
||
<span class="glyphicon glyphicon-star"></span> | ||
|
||
<span class="glyphicon glyphicon-star"></span> | ||
|
||
<span class="glyphicon glyphicon-star"></span> | ||
|
||
<!-- empty stars: --> | ||
|
||
<span class="glyphicon glyphicon-star-empty"></span> | ||
|
||
</font> | ||
|
||
|
||
</blockquote> | ||
|
||
<dl> | ||
<dt>Reviews served by:</dt> | ||
<u>reviews-v2-6dd458b5db-frrlb</u> | ||
|
||
</dl> | ||
... | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we need to include this step. I know it was included in the OSSM docs but this example just shows that bookinfo is working correctly however users will not be migrating bookinfo. They will be migrating their own apps which will have their own ways of verifying that they work correctly and having this bookinfo specific step here may confuse people and I think is unnecessary. Simply having the previous step showing the updated proxy connected to the 3.0 controlplane is enough.
*2*. `curl` the productpage pod in `bookinfo` to ensure proxies can still communicate with one another. | ||
|
||
```sh | ||
oc exec -it -n bookinfo deployments/productpage-v1 -c istio-proxy -- curl localhost:9080/productpage | ||
``` | ||
|
||
You should see | ||
|
||
```html | ||
... | ||
<p>Absolutely fun and entertaining. The play lacks thematic depth when compared to other plays by Shakespeare.</p> | ||
<small>Reviewer2</small> | ||
|
||
|
||
<font color="black"> | ||
<!-- full stars: --> | ||
|
||
<span class="glyphicon glyphicon-star"></span> | ||
|
||
<span class="glyphicon glyphicon-star"></span> | ||
|
||
<span class="glyphicon glyphicon-star"></span> | ||
|
||
<span class="glyphicon glyphicon-star"></span> | ||
|
||
<!-- empty stars: --> | ||
|
||
<span class="glyphicon glyphicon-star-empty"></span> | ||
|
||
</font> | ||
|
||
|
||
</blockquote> | ||
|
||
<dl> | ||
<dt>Reviews served by:</dt> | ||
<u>reviews-v2-6dd458b5db-frrlb</u> | ||
|
||
</dl> | ||
... | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as below with removing this example since it is specific to bookinfo and not generally useful to users' actual apps.
*2*. `curl` the productpage pod in `bookinfo` to ensure proxies can still communicate with one another. | ||
|
||
```sh | ||
oc exec -it -n bookinfo deployments/productpage-v1 -c istio-proxy -- curl localhost:9080/productpage | ||
``` | ||
|
||
You should see | ||
|
||
```html | ||
... | ||
<p>Absolutely fun and entertaining. The play lacks thematic depth when compared to other plays by Shakespeare.</p> | ||
<small>Reviewer2</small> | ||
|
||
|
||
<font color="black"> | ||
<!-- full stars: --> | ||
|
||
<span class="glyphicon glyphicon-star"></span> | ||
|
||
<span class="glyphicon glyphicon-star"></span> | ||
|
||
<span class="glyphicon glyphicon-star"></span> | ||
|
||
<span class="glyphicon glyphicon-star"></span> | ||
|
||
<!-- empty stars: --> | ||
|
||
<span class="glyphicon glyphicon-star-empty"></span> | ||
|
||
</font> | ||
|
||
|
||
</blockquote> | ||
|
||
<dl> | ||
<dt>Reviews served by:</dt> | ||
<u>reviews-v2-6dd458b5db-frrlb</u> | ||
|
||
</dl> | ||
... | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment here as above.
*2*. Ensure the `bookinfo` application is still working correctly. | ||
|
||
```sh | ||
oc exec -it -n bookinfo deployments/productpage-v1 -c istio-proxy -- curl localhost:9080/productpage | ||
``` | ||
|
||
Example response: | ||
|
||
```html | ||
... | ||
<p>Absolutely fun and entertaining. The play lacks thematic depth when compared to other plays by Shakespeare.</p> | ||
<small>Reviewer2</small> | ||
|
||
|
||
<font color="black"> | ||
<!-- full stars: --> | ||
|
||
<span class="glyphicon glyphicon-star"></span> | ||
|
||
<span class="glyphicon glyphicon-star"></span> | ||
|
||
<span class="glyphicon glyphicon-star"></span> | ||
|
||
<span class="glyphicon glyphicon-star"></span> | ||
|
||
<!-- empty stars: --> | ||
|
||
<span class="glyphicon glyphicon-star-empty"></span> | ||
|
||
</font> | ||
|
||
|
||
</blockquote> | ||
|
||
<dl> | ||
<dt>Reviews served by:</dt> | ||
<u>reviews-v2-6dd458b5db-frrlb</u> | ||
|
||
</dl> | ||
... | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here.
…o see the whole picture
…it 2 commits ago (Squash)
… before starting to migratin (Squash)
…ltitenant content (Squash)
aeb6a37
to
79dde70
Compare
…y migration content for 3.0, not just the 2.x content
@gwynnemonahan: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
THIS PR IS BEING USED TO STRUCTURE ALL OSSM 2.6.Z TO 3.0 MIGRATION CONTENT
Content in this PR is not in line with current style. This PR is being used to establish the Information Architecture of the Migration Guides.
This PR will likely be broken up into separate PRs that correspond to the respective section Jiras found in the Migration Guides Epic.
01/21/2025: This PR has been shared via the Service Mesh AMA meeting notes, the Service Mesh Program Call notes, and the team-ossm-all Slack channel for the purposes of feedback on the information architecture, how users may move through this content, etc.
OSSM 3.0 GA
https://issues.redhat.com/browse/OSSM-8673
Merge to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-main
Cherry pick to: TBD but likely something like https://github.com/openshift/openshift-docs/tree/service-mesh-docs-3.0.0
This PR is part of the standalone doc set for the OpenShift Service Mesh project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.
Version(s):
Technology Preview.
OSSM 3.0 is moving to stand alone format so it will not be cherry-picked back to OCP core branches.
Issue:
https://issues.redhat.com/browse/OSSM-8673
Link to docs preview:
https://86912--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/migrating/checklist/ossm-migrating-migration-guides-assembly.html
https://86912--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/migrating/checklist/ossm-migrating-premigration-checklist-assembly.html
https://86912--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/migrating/checklist/ossm-migrating-read-me-assembly.html
https://86912--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/migrating/multitenant/ossm-migrating-multitenant-assembly.html
https://86912--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/migrating/multitenant/ossm-migrating-multitenant-cert-manager-assembly.html
https://86912--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/migrating/ossm-migrating-from-2-6-to-3-0-assembly.html
QE review:
Additional information: