Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDOCS-12922: adds 4.16.30 relnote MicroShift #86911

Open
wants to merge 1 commit into
base: enterprise-4.16
Choose a base branch
from
Open

OSDOCS-12922: adds 4.16.30 relnote MicroShift #86911

wants to merge 1 commit into from

Conversation

ShaunaDiaz
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz commented Jan 10, 2025 •
edited
Loading

Version(s):
4.16

Issue:
OSDOCS-12922

Link to docs preview:
microshift-4-16-30-dp_release-notes

QE review:

  • QE has approved this change.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 10, 2025 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-12922 which is a valid jira issue.

In response to this:

Version(s):
4.16

Issue:
OSDOCS-12922

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ShaunaDiaz ShaunaDiaz added this to the Continuous Release milestone Jan 10, 2025
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 10, 2025
@ocpdocs-previewbot
Copy link

🤖 Fri Jan 10 17:06:00 - Prow CI generated the docs preview:

https://86911--ocpdocs-pr.netlify.app/microshift/latest/microshift_release_notes/microshift-4-16-release-notes.html

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 10, 2025

@ShaunaDiaz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 10, 2025 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-12922 which is a valid jira issue.

In response to this:

Version(s):
4.16

Issue:
OSDOCS-12922

Link to docs preview:
microshift-4-16-30-dp_release-notes

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ShaunaDiaz ShaunaDiaz added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 10, 2025
@opayne1 opayne1 added peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-4.16 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 10, 2025
opayne1
opayne1 reviewed Jan 10, 2025
View reviewed changes
Copy link
Contributor

@opayne1 opayne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question, but otherwise LGTM!

microshift_release_notes/microshift-4-16-release-notes.adoc

Issued: 15 January 2025

{product-title} release 4.16.30 is now available. The list of bug fixes that are included in the update is attached to the link:https://access.redhat.com/errata/RHBA-2025:0142[RHBA-2025:0142] advisory. The images that are included in the update are provided by the link:https://access.redhat.com/errata/RHSA-2025:0140[RHSA-2025:0140] advisory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been out of the rel note space for a bit now but shouldn't the title also say it has security updates because the images advisory is an RHSA?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't know; there's never been an engineering differentiation for the security updates to know if all of the OCP ones effect MicroShift.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh gotcha! That makes sense!

@opayne1 opayne1 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opayne1 opayne1 opayne1 left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.16 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
4 participants
@ShaunaDiaz @openshift-ci-robot @ocpdocs-previewbot @opayne1