Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDOCS-6962_RN#adding release note #86899

Merged
merged 1 commit into from
Jan 21, 2025
Merged

OSDOCS-6962_RN#adding release note #86899

merged 1 commit into from
Jan 21, 2025

Conversation

brendan-daly-red-hat
Copy link
Contributor

@brendan-daly-red-hat brendan-daly-red-hat commented Jan 10, 2025 •
edited
Loading

Version:
4.18

Issue:
https://issues.redhat.com/browse/OSDOCS-6962

Link to docs preview:
Configuring the ovn-kubernetes join subnet during cluster installation

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 10, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 10, 2025 •
edited
Loading

🤖 Tue Jan 21 09:59:27 - Prow CI generated the docs preview:

https://86899--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-18-release-notes.html

@brendan-daly-red-hat brendan-daly-red-hat force-pushed the OSDOCS-6962_RN branch 3 times, most recently from b8f1a06 to 8cb6bdf Compare January 13, 2025 11:41
bscott-rh
bscott-rh reviewed Jan 13, 2025
View reviewed changes
release_notes/ocp-4-18-release-notes.adoc Outdated
@@ -419,6 +419,12 @@ For more information, see xref:../nodes/clusters/nodes-cluster-enabling-features
[id="ocp-release-notes-installation-and-update_{context}"]
=== Installation and update

[id="ocp-4.18-installation-and-update-byoip-ovn_{context}"]
==== Bring your own IPv4 (BYOIP) join subnet feature is enabled on `ovn-kubernetes` for Virtual Private Cloud (VPC)
With this release, you can configure the IPv4 join subnet that is used internally by `ovn-kubernetes` in a Bring your own (BYO) Virtual Private Cloud (VPC). You can set the `OVNKubernetesConfig` parameter in the `install-config.yaml` file and deploy the cluster into an existing VPC.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
With this release, you can configure the IPv4 join subnet that is used internally by `ovn-kubernetes` in a Bring your own (BYO) Virtual Private Cloud (VPC). You can set the `OVNKubernetesConfig` parameter in the `install-config.yaml` file and deploy the cluster into an existing VPC.
With this release, you can configure the IPv4 join subnet that is used internally by `ovn-kubernetes` when installing a cluster into an existing Virtual Private Cloud (VPC). You can set the `internalJoinSubnet` parameter in the `install-config.yaml` file and deploy the cluster into an existing VPC.

@brendan-daly-red-hat
Copy link
Contributor Author

@yunjiang29, PTAL at the draft release note.

yunjiang29
yunjiang29 reviewed Jan 14, 2025
View reviewed changes
release_notes/ocp-4-18-release-notes.adoc Outdated
@@ -419,6 +419,12 @@ For more information, see xref:../nodes/clusters/nodes-cluster-enabling-features
[id="ocp-release-notes-installation-and-update_{context}"]
=== Installation and update

[id="ocp-4.18-installation-and-update-byoip-ovn_{context}"]
==== Bring your own IPv4 (BYOIP) join subnet feature is enabled on `ovn-kubernetes` for Virtual Private Cloud (VPC)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Searching the existing document, BYOIP refers to Bring your own public IPv4 addresses [1], which is for publicIpv4Pool field, but internalJoinSubnet uses internal/private addresses, I think we can update the title like Add support to configure IPv4 subnet to customize internal OVN network to reduce the confusion.

@patrickdillon do you have any idea about the title?

[1] https://docs.openshift.com/container-platform/4.17/installing/installing_aws/installation-config-parameters-aws.html

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like

Install-time configuration for the ovn-kubernetes join subnet is now enabled

yunjiang29
yunjiang29 reviewed Jan 14, 2025
View reviewed changes
release_notes/ocp-4-18-release-notes.adoc Outdated
@@ -419,6 +419,12 @@ For more information, see xref:../nodes/clusters/nodes-cluster-enabling-features
[id="ocp-release-notes-installation-and-update_{context}"]
=== Installation and update

[id="ocp-4.18-installation-and-update-byoip-ovn_{context}"]
==== Bring your own IPv4 (BYOIP) join subnet feature is enabled on `ovn-kubernetes` for Virtual Private Cloud (VPC)
With this release, you can configure the IPv4 join subnet that is used internally by `ovn-kubernetes` when installing a cluster into an existing Virtual Private Cloud (VPC). You can set the `internalJoinSubnet` parameter in the `install-config.yaml` file and deploy the cluster into an existing VPC.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature is not limited to BYO-VPC:

Suggested change
With this release, you can configure the IPv4 join subnet that is used internally by `ovn-kubernetes` when installing a cluster into an existing Virtual Private Cloud (VPC). You can set the `internalJoinSubnet` parameter in the `install-config.yaml` file and deploy the cluster into an existing VPC.
With this release, you can configure the IPv4 join subnet that is used internally by `ovn-kubernetes` when installing a cluster. You can set the `internalJoinSubnet` parameter in the `install-config.yaml` file and deploy the cluster into an existing VPC.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 it is not limited to byo-vpc. That said, byo vpc is the primary use case. Suggested changes look good.

@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 17, 2025
@brendan-daly-red-hat brendan-daly-red-hat force-pushed the OSDOCS-6962_RN branch 2 times, most recently from 64f85ed to c66fd11 Compare January 17, 2025 11:09
@brendan-daly-red-hat
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 17, 2025
@xenolinux xenolinux added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 17, 2025
@xenolinux xenolinux added this to the Planned for 4.18 GA milestone Jan 17, 2025
xenolinux
xenolinux reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment on the heading otherwise LGTM

release_notes/ocp-4-18-release-notes.adoc Outdated
@@ -419,6 +419,12 @@ For more information, see xref:../nodes/clusters/nodes-cluster-enabling-features
[id="ocp-release-notes-installation-and-update_{context}"]
=== Installation and update

[id="ocp-4.18-installation-and-update-ovn-kubernetes-join-subnet_{context}"]
==== Install-time configuration for the `ovn-kubernetes` join subnet feature is enabled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
==== Install-time configuration for the `ovn-kubernetes` join subnet feature is enabled
==== Configuring the ovn-kubernetes join subnet during cluster installation

OR

Suggested change
==== Install-time configuration for the `ovn-kubernetes` join subnet feature is enabled
==== Configuring the IPV4 join subnet during cluster installation

Instead of "Install-time" I think "during cluster installation" is clearer.

@xenolinux xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 17, 2025
@brendan-daly-red-hat brendan-daly-red-hat force-pushed the OSDOCS-6962_RN branch 2 times, most recently from 08a578d to a5d46d5 Compare January 20, 2025 09:20
@brendan-daly-red-hat
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 20, 2025
@adellape adellape added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jan 20, 2025
adellape
adellape reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@adellape adellape left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit, but might as well fix up before merge.

Please re-queue when ready. Thank you!

release_notes/ocp-4-18-release-notes.adoc Outdated
@@ -419,6 +419,12 @@ For more information, see xref:../nodes/clusters/nodes-cluster-enabling-features
[id="ocp-release-notes-installation-and-update_{context}"]
=== Installation and update

[id="ocp-4.18-installation-and-update-ovn-kubernetes-join-subnet_{context}"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No .s in IDs:

Suggested change
[id="ocp-4.18-installation-and-update-ovn-kubernetes-join-subnet_{context}"]
[id="ocp-4-18-installation-and-update-ovn-kubernetes-join-subnet_{context}"]

@adellape adellape removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Jan 20, 2025
@adellape adellape self-assigned this Jan 20, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 21, 2025

@brendan-daly-red-hat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@brendan-daly-red-hat
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 21, 2025
@xenolinux xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jan 21, 2025
@xenolinux xenolinux merged commit 3b7bd15 into openshift:enterprise-4.18 Jan 21, 2025
2 checks passed
@xenolinux xenolinux removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bscott-rh bscott-rh bscott-rh left review comments

@yunjiang29 yunjiang29 yunjiang29 left review comments

@xenolinux xenolinux xenolinux left review comments

@patrickdillon patrickdillon patrickdillon left review comments

@adellape adellape adellape left review comments

Assignees

@adellape adellape

Labels
branch/enterprise-4.18 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Planned for 4.18 GA
Development

Successfully merging this pull request may close these issues.
7 participants
@brendan-daly-red-hat @ocpdocs-previewbot @adellape @patrickdillon @xenolinux @yunjiang29 @bscott-rh