-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-10640-12: 4.12 Added clarification point to disk partition BM… #73362
Conversation
@dfitzmau: This pull request references Jira Issue OCPBUGS-10640, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Fri Mar 22 11:10:17 - Prow CI generated the docs preview: |
3b4a7a2
to
bcbb5e9
Compare
/lgtm |
@dfitzmau: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/label peer-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that you already received peer review comments on this material, so those changes should also be made here. Otherwise lgtm!
Thanks, @kcarmichael08 . Yeah, I'll be creating a follow-up PR for Brian's comments. The restructing of 4.15 vSphere docs means that I'll need to create multiple PRs for backporting content. I'll addres Brian's comment and send the PRs stragiht for merging to stay out of the feedback-varience loop across multiple PR. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dfitzmau: This pull request references Jira Issue OCPBUGS-10640. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
SEE #67707 FOR SME APPROVAL.
OCPBUGS-10640
Version(s):
4.12
For 4.13 and 4.12, ensure you do not remove:
Link to docs preview:
Disk partioning
Additional information: