Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Add NodeDisruptionPolicy docs #4336

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

djoshy
Copy link
Contributor

@djoshy djoshy commented Apr 25, 2024

This adds:

  • docs for NodeDisruptionPolicy,
  • rename MachineConfiguration.md -> MachineConfig.md
  • minor logging fixes in the daemon while performing NodeDisruption actions

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 25, 2024
@openshift-ci-robot
Copy link
Contributor

@djoshy: This pull request explicitly references no jira issue.

In response to this:

This adds:

  • docs for NodeDisruptionPolicy,
  • rename MachineConfiguration.md -> MachineConfig.md
  • minor logging fixes in the daemon while performing NodeDisruption actions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2024
Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
@djoshy djoshy force-pushed the node-disrupt-nit-fix branch 3 times, most recently from 23f1adc to b78e034 Compare April 26, 2024 19:54
@djoshy djoshy force-pushed the node-disrupt-nit-fix branch from b78e034 to f84a504 Compare April 29, 2024 11:47
@djoshy djoshy marked this pull request as ready for review April 29, 2024 11:48
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2024
@djoshy djoshy force-pushed the node-disrupt-nit-fix branch from f84a504 to 212846e Compare April 29, 2024 12:43
@sinnykumari
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
Copy link
Contributor

openshift-ci bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Apr 29, 2024

@djoshy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-upgrade-out-of-change 212846e link false /test e2e-azure-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 4ea63f5 into openshift:master Apr 29, 2024
14 of 15 checks passed
@djoshy djoshy deleted the node-disrupt-nit-fix branch April 29, 2024 15:56
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.17.0-202404291910.p0.g4ea63f5.assembly.stream.el9 for distgit ose-machine-config-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants