Revert "daemon: Make binary writing idempotent" #3831
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@dgoodwin: This pull request references Jira Issue OCPBUGS-16921, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Not entirely sure if this is the cause of failure but we can debug that later. Fine with getting this reverted if this helps us unblock our payload. |
|
/payload-aggregate periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade 3 |
|
@dgoodwin: trigger 1 job(s) for the /payload-(job|aggregate) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c38cf560-3061-11ee-8e01-26090682b9c6-0 |
openshift-ci
bot
added
the
approved
|
umm, PR #3825 also made it to nightly 4.14.0-0.nightly-2023-08-01-020603 . Shouldn't we also seeing this issue in this nightly? |
|
That payload is not completing for some reason, something is broken there, so we've got no minor upgrade signal, pretty confident we will see it there once this is resolved. |
|
yeah, missed that this nightly haven't completed. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, sinnykumari The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
looks like payload job got killed. rerunning |
|
@sinnykumari: trigger 1 job(s) for the /payload-(job|aggregate) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7e69f9e0-3077-11ee-8425-3e50a8856472-0 |
|
#3832 should fix the bugs that this caused |
|
Pod got deleted unexpectedly... 😠 /payload-aggregate periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade 3 |
|
@dgoodwin: An error was encountered. No known errors were detected, please see the full error message for details. Full error message.
could not check if the user dgoodwin is trusted for pull request openshift/machine-config-operator#3831: error checking dgoodwin for trust: failed to check if comment came from myself: fetching userdata from GitHub: Get "http://ghproxy/app": dial tcp 172.30.229.2:80: i/o timeout
Please contact an administrator to resolve this issue. |
|
We're going to merge, we this really looks too related to not be the cause. Authors: please bear in mind any implications for this code in 4.13 as Trevor called out on slack. If we're wrong and this is not the cause, our deepest apologies :) |
|
/jira refresh |
|
@dgoodwin: An error was encountered querying GitHub for users with public email ([email protected]) for bug OCPBUGS-16921 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details. Full error message.
Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: connect: connection refused
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Sure, makes sense to me to merge, it will re-break dnf-based RHEL nodes but I think that's fine, we can redo #3832 on top of the revert. |
|
Thanks @cgwalters Anyone know how to get past whatever is broken with the jira label? I moved the bug back to ASSIGNED |
cgwalters
changed the title
openshift-ci-robot
removed
jira/valid-reference
|
@dgoodwin: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Do we need a jira to merge? |
|
Well anyways if we just want to merge this, for some reason I still have the "merge button" here on this repository so...I can just...push it? |
Reverts #3825
Jira issues: https://issues.redhat.com/browse/TRT-1175
Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.
Not 100% sure this wasn't a flake as it's only had once payload to surface, but it looks real to me.
CC: @sinnykumari