Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

templates/common/_base/units: disable Zincati service #1919

Merged
merged 1 commit into from
Jul 16, 2020
Merged

templates/common/_base/units: disable Zincati service #1919

merged 1 commit into from
Jul 16, 2020

Conversation

LorbusChris
Copy link
Member

@LorbusChris LorbusChris commented Jul 9, 2020 •
edited
Loading

This disables Zincati updates on FCOS nodes - no-op on RHCOS.

@LorbusChris LorbusChris changed the title templates/common/_base/files: disable Zincati templates/common/_base/files: disable Zincati updates Jul 9, 2020
@LorbusChris
Copy link
Member Author

/retest

3 similar comments
@LorbusChris
Copy link
Member Author

/retest

@LorbusChris
Copy link
Member Author

/retest

@LorbusChris
Copy link
Member Author

/retest

@cgwalters
Copy link
Member

/lgtm
(Personally I would say disable the service entirely, but this is fine too)

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 14, 2020
@LorbusChris
Copy link
Member Author

We should be able to disable the service entirely once coreos/fedora-coreos-tracker#392 / systemd/systemd#15205 is fixed

@cgwalters
Copy link
Member

We should be able to disable the service entirely once coreos/fedora-coreos-tracker#392 / systemd/systemd#15205 is fixed

I don't think we need to block on that, see
#1907
(Certainly having systemd fixed would be really nice)

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@LorbusChris
Copy link
Member Author

Oh right, let's do it that way :)
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2020
@LorbusChris LorbusChris changed the title templates/common/_base/files: disable Zincati updates templates/common/_base/files: disable Zincati service Jul 14, 2020
@LorbusChris
templates/common/_base/units: disable zincati
f0d01bf 
Zincati is the update agent used on standalone Fedora CoreOS installations;
it is not used on OKD clusters.
Zincati is not shipped in RHEL CoreOS.

This adds a condition to zincati.service which it can't fullfil,
so that Fedora CoreOS nodes will not run it.
@LorbusChris
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2020
@LorbusChris LorbusChris changed the title templates/common/_base/files: disable Zincati service templates/common/_base/units: disable Zincati service Jul 15, 2020
@LorbusChris
Copy link
Member Author

/retest

1 similar comment
@LorbusChris
Copy link
Member Author

/retest

@runcom
Copy link
Member

runcom commented Jul 16, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, LorbusChris, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 04dd5cf into openshift:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters Awaiting requested review from cgwalters

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

Assignees

@cgwalters cgwalters

@runcom runcom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LorbusChris @cgwalters @openshift-bot @runcom @openshift-ci-robot @openshift-merge-robot