Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/e2e: Refactor and reduce test run time #1884

Merged

Conversation

kikisdeliveryservice
Copy link
Contributor

@kikisdeliveryservice kikisdeliveryservice commented Jun 30, 2020

Refactor mco e2e tests and reduce time of the e2e tests by ~50% by removing duplicative tests & using custom pools. Current runtime based on this PR is ~55m for the mco e2e tests to run down from ~100min.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 30, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2020
@kikisdeliveryservice
Copy link
Contributor Author

/skip

1 similar comment
@kikisdeliveryservice
Copy link
Contributor Author

/skip

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2020
@kikisdeliveryservice
Copy link
Contributor Author

Pod pending timeout. <-- seem to be some weird e2e issues in play ignoring for now.

@kikisdeliveryservice kikisdeliveryservice force-pushed the refactor-e2e branch 3 times, most recently from 9936974 to e4a3f1f Compare July 7, 2020 00:03
@kikisdeliveryservice
Copy link
Contributor Author

Got this fixed locally will repush tomorrow.

@kikisdeliveryservice
Copy link
Contributor Author

/skip

@kikisdeliveryservice
Copy link
Contributor Author

So I decided to shoot the moon even tho I got the e2e down to ~62 min and use custom pools for kargs.. That's when it all went south. I think there's an issue rolling back - I opened #1912 to test (also deleted all the other e2e so hopefully it runs a lot faster over there too):

Ok seeing same error in this ci run that I saw in my local cluster: https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/1884/pull-ci-openshift-machine-config-operator-master-e2e-gcp-op/1280664102313660416/artifacts/e2e-gcp-op/machineconfigpools.json

@kikisdeliveryservice
Copy link
Contributor Author

Ok will update our test karg arguments as there seems to be a bug in rpmostree : #1912 (comment)

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2020
@kikisdeliveryservice kikisdeliveryservice force-pushed the refactor-e2e branch 2 times, most recently from 9f1b7b2 to d8b4f7d Compare July 8, 2020 20:41
@kikisdeliveryservice
Copy link
Contributor Author

kikisdeliveryservice commented Jul 8, 2020

Fixing test kargs allowed rollback to run sucessfully. Last successful test run was 55m.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2020
@kikisdeliveryservice kikisdeliveryservice requested review from runcom and removed request for runcom July 21, 2020 00:44
@runcom
Copy link
Member

runcom commented Jul 21, 2020

Test started last Wednesday at 10:20 AM passed after 2h27m45s.
Test started last Thursday at 10:53 PM passed after 2h28m50s.
Test started today at 2:44 AM passed after 1h48m46s

I'd say... 😌

/approve

@kikisdeliveryservice kikisdeliveryservice changed the title [WIP]: Refactor e2e tests/e2e: Refactor e2e to reduce test run time Jul 21, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2020
@kikisdeliveryservice kikisdeliveryservice changed the title tests/e2e: Refactor e2e to reduce test run time tests/e2e: Refactor and reduce test run time Jul 21, 2020
@kikisdeliveryservice
Copy link
Contributor Author

@runcom this is ready whenever you are 😸

@kikisdeliveryservice
Copy link
Contributor Author

/skip

@kikisdeliveryservice
Copy link
Contributor Author

/retest

@cgwalters
Copy link
Member

Didn't deep dive but LGTM overall!

In the future one thing we can consider is using temporary machinesets too (gets into #1720 ) - we can parallelize the tests arbitrarily by having a MCP+machineset per test scenario (at the cost of more $ of course).

@runcom
Copy link
Member

runcom commented Jul 27, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice,runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@kikisdeliveryservice
Copy link
Contributor Author

/skip

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 27, 2020

@kikisdeliveryservice: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-proxy 266ce61 link /test e2e-aws-proxy
ci/prow/okd-e2e-aws 266ce61 link /test okd-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kikisdeliveryservice
Copy link
Contributor Author

this is a test refactor in e2e-gcp-op, there's not reason to keep retesting on the known broken e2e-aws and waste resources since this doesn't touch at that all and it's retesting a billion times at this point

/override e2e-aws

@openshift-ci-robot
Copy link
Contributor

@kikisdeliveryservice: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • e2e-aws

Only the following contexts were expected:

  • ci/prow/e2e-aws
  • ci/prow/e2e-aws-proxy
  • ci/prow/e2e-aws-scaleup-rhel7
  • ci/prow/e2e-gcp-op
  • ci/prow/e2e-gcp-upgrade
  • ci/prow/e2e-metal-ipi
  • ci/prow/e2e-ovn-step-registry
  • ci/prow/images
  • ci/prow/okd-e2e-aws
  • ci/prow/okd-images
  • ci/prow/unit
  • ci/prow/verify
  • tide

In response to this:

this is a test refactor in e2e-gcp-op, there's not reason to keep retesting on the known broken e2e-aws and waste resources since this doesn't touch at that all and it's retesting a billion times at this point

/override e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kikisdeliveryservice
Copy link
Contributor Author

/override ci/prow/e2e-aws

@openshift-ci-robot
Copy link
Contributor

@kikisdeliveryservice: Overrode contexts on behalf of kikisdeliveryservice: ci/prow/e2e-aws

In response to this:

/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit b9ce2e4 into openshift:master Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants