MULTIARCH-3793: Power VS: Add mad and wdc assupported region #7773
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@mjturek: This pull request references MULTIARCH-3793 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Now that this PR is making "s1022" SysType support official, we might want to add/update some validation logic near installer/pkg/types/powervs/validation/machinepool_test.go Lines 134 to 139 in e80d50a |
data/data/coreos/rhcos.json
Outdated
| @@ -350,6 +350,12 @@ | |||
| "bucket": "rhcos-powervs-images-eu-de", | |||
| "url": "https://s3.eu-de.cloud-object-storage.appdomain.cloud/rhcos-powervs-images-eu-de/rhcos-415-92-202310310037-0-ppc64le-powervs.ova.gz" | |||
| }, | |||
| "eu-es": { | |||
There was a problem hiding this comment.
Aren't these auto generated? Ex: #7654
There was a problem hiding this comment.
it is but we don't want to wait for it to get generated to add the region
There was a problem hiding this comment.
I don't think we are supposed to edit this file. @patrickdillon have we done this in the past?
There was a problem hiding this comment.
hmmm fair, we could also initially point mad at a different region (eu-gb may be the next closest but would have to check).
Mark also suggested @mike-nguyen may have an opinion here!
There was a problem hiding this comment.
Pointing to a different region sounds hacky.
There was a problem hiding this comment.
There is a PR up to update the json: #7770
There was a problem hiding this comment.
These are generated from the RHCOS builds. eu-es was added recently with coreos/coreos-assembler#3651. Our pipeline will replicate to these regions then we generate the RHCOS image references for the installer.
There was a problem hiding this comment.
awesome! I'll remove it from this PR
|
/retest-required |
|
/test ? |
|
@mjturek: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test okd-e2e-aws-ovn-upgrade |
|
/test tf-fmt |
|
/test okd-scos-verify-codegen |
|
/test okd-scos-unit |
|
/assign @r4f4 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: r4f4 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test golint |
|
/test govet |
|
/test shellcheck |
|
/test okd-scos-images |
|
/test okd-unit |
|
/test okd-scos-images |
1 similar comment
|
/test okd-scos-images |
|
@mjturek: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
No description provided.