-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: AGENT-601: support for okd-scos #7112
Conversation
@andfasano: This pull request references AGENT-601 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/draft |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@andfasano: This pull request references AGENT-601 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fcosTAG = "okd" | ||
scosTAG = "scos" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fcosTAG = "okd" | |
scosTAG = "scos" | |
okdTag = "okd" | |
fcosTAG = "fcos" | |
scosTAG = "scos" |
the okd
and fcos
Go build tags used elsewhere in the installer are synonymous. Let's add an okdTAG
here and treat it like fcosTAG
.
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
We're not going to add an
Voting to close this PR. |
Not a problem, as this PR was meant just to explore the ABI gaps to support OKD scos. Is there any documentation available about the current distribution? |
@andfasano: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This is PoC to explore the required changes to support okd-scos for agent-based installer.
Notes:
scos.json
is identical to the previousfcos.json
except for x86_64 metal isomachine-os-images
has been excluded because not yet available for scos, so using a direct download (that would be required for disconnected installs)