-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1861026: update boot images to perform other rpm-ostree operations after OS rebase #4125
Bug 1861026: update boot images to perform other rpm-ostree operations after OS rebase #4125
Conversation
…s after OS rebase This fixes the issues which we have today during cluster install involving multiple rpm-ostree operations such as both OS rebase and rt-kernel switch. PR openshift/machine-config-operator#2029 fixes the issue for day2 and we need to update boot images to include machine-config-daemon containing the fixes for day1. boot images update contains machine-config-daemon-4.5.0-202008280032.p0.git.2558.a93c8dc.el8 which contains the necessary fixes. Used: $ hack/update-rhcos-bootimage.py https://releases-art-rhcos.svc.ci.openshift.org/art/storage/releases/rhcos-4.5/45.82.202008280129-0/x86_64/meta.json amd64
@sinnykumari: This pull request references Bugzilla bug 1861026, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/bugzilla refresh |
@sinnykumari: This pull request references Bugzilla bug 1861026, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sinnykumari: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Is this a blocker for verifying https://bugzilla.redhat.com/show_bug.cgi?id=1861026? |
yeah, since this will cover verifying the issue during day1 as well. |
/bugzilla refresh |
@sinnykumari: This pull request references Bugzilla bug 1861026, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hmm. I agree updating the bootimages is probably a good idea for this. But strictly speaking I don't think we need to do so to verify the BZ - we can reproduce starting from 4.4.4 and upgrade. |
right. With this PR we can also verify that day1 kernel-rt install works as expected (https://bugzilla.redhat.com/show_bug.cgi?id=1861026#c18) |
@sinnykumari Updating the boot images as part of a z-stream release is something we only want to do sparingly. Since the day 2 operation is fixed in 4.5 and users could use that, do you think it is necessary to pursue this PR? |
I am not sure about the impact to users, will defer the decision to @ashcrow . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slightly leaning to defer this but if we gather a stronger argument why we need this then I'm OK with doing it.
I'll break the tie 😄 Let's defer the bump. If we have something more urgent that needs a boot image bump in the future this fix will hop on as well. |
thanks Colin and Steve for your input, definitely we can do the bootimage bump in future if it is important. |
@sinnykumari: This pull request references Bugzilla bug 1861026. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This fixes the issues which we have today during cluster install
involving multiple rpm-ostree operations such as both OS rebase and
rt-kernel switch.
PR openshift/machine-config-operator#2029 fixes
the issue for day2 and we need to update boot images to include
machine-config-daemon containing the fixes for day1.
boot images update contains machine-config-daemon-4.5.0-202008280032.p0.git.2558.a93c8dc.el8
which contains the necessary fixes.
Used:
$ hack/update-rhcos-bootimage.py https://releases-art-rhcos.svc.ci.openshift.org/art/storage/releases/rhcos-4.5/45.82.202008280129-0/x86_64/meta.json amd64