Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1861026: update boot images to perform other rpm-ostree operations after OS rebase #4125

Closed

Conversation

sinnykumari
Copy link
Contributor

This fixes the issues which we have today during cluster install
involving multiple rpm-ostree operations such as both OS rebase and
rt-kernel switch.
PR openshift/machine-config-operator#2029 fixes
the issue for day2 and we need to update boot images to include
machine-config-daemon containing the fixes for day1.

boot images update contains machine-config-daemon-4.5.0-202008280032.p0.git.2558.a93c8dc.el8
which contains the necessary fixes.

Used:

$ hack/update-rhcos-bootimage.py https://releases-art-rhcos.svc.ci.openshift.org/art/storage/releases/rhcos-4.5/45.82.202008280129-0/x86_64/meta.json amd64

…s after OS rebase

This fixes the issues which we have today during cluster install
involving multiple rpm-ostree operations such as both OS rebase and
rt-kernel switch.
PR openshift/machine-config-operator#2029 fixes
the issue for day2 and we need to update boot images to include
machine-config-daemon containing the fixes for day1.

boot images update contains machine-config-daemon-4.5.0-202008280032.p0.git.2558.a93c8dc.el8
which contains the necessary fixes.

Used:

$ hack/update-rhcos-bootimage.py https://releases-art-rhcos.svc.ci.openshift.org/art/storage/releases/rhcos-4.5/45.82.202008280129-0/x86_64/meta.json amd64
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Sep 2, 2020
@openshift-ci-robot
Copy link
Contributor

@sinnykumari: This pull request references Bugzilla bug 1861026, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
  • expected dependent Bugzilla bug 1873249 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is CLOSED (NOTABUG) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1861026: update boot images to perform other rpm-ostree operations after OS rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 2, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign crawford
You can assign the PR to them by writing /assign @crawford in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sinnykumari
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@sinnykumari: This pull request references Bugzilla bug 1861026, which is invalid:

  • expected dependent Bugzilla bug 1873249 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is CLOSED (NOTABUG) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sinnykumari
Copy link
Contributor Author

/cc @runcom @cgwalters @miabbott @ashcrow

@openshift-ci-robot
Copy link
Contributor

@sinnykumari: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-ovirt 56c302b link /test e2e-ovirt
ci/prow/e2e-openstack 56c302b link /test e2e-openstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sohankunkerkar
Copy link
Member

Is this a blocker for verifying https://bugzilla.redhat.com/show_bug.cgi?id=1861026?

@sinnykumari
Copy link
Contributor Author

yeah, since this will cover verifying the issue during day1 as well.

@sinnykumari
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 2, 2020
@openshift-ci-robot
Copy link
Contributor

@sinnykumari: This pull request references Bugzilla bug 1861026, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1873249 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1873249 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters
Copy link
Member

Hmm. I agree updating the bootimages is probably a good idea for this. But strictly speaking I don't think we need to do so to verify the BZ - we can reproduce starting from 4.4.4 and upgrade.

@sinnykumari
Copy link
Contributor Author

sinnykumari commented Sep 2, 2020

right. With this PR we can also verify that day1 kernel-rt install works as expected (https://bugzilla.redhat.com/show_bug.cgi?id=1861026#c18)

@miabbott
Copy link
Member

miabbott commented Sep 2, 2020

@sinnykumari Updating the boot images as part of a z-stream release is something we only want to do sparingly. Since the day 2 operation is fixed in 4.5 and users could use that, do you think it is necessary to pursue this PR?

@sinnykumari
Copy link
Contributor Author

sinnykumari commented Sep 2, 2020

I am not sure about the impact to users, will defer the decision to @ashcrow .

Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly leaning to defer this but if we gather a stronger argument why we need this then I'm OK with doing it.

@ashcrow
Copy link
Member

ashcrow commented Sep 3, 2020

I'll break the tie 😄 Let's defer the bump. If we have something more urgent that needs a boot image bump in the future this fix will hop on as well.

@sinnykumari
Copy link
Contributor Author

thanks Colin and Steve for your input, definitely we can do the bootimage bump in future if it is important.

@sinnykumari sinnykumari closed this Sep 4, 2020
@openshift-ci-robot
Copy link
Contributor

@sinnykumari: This pull request references Bugzilla bug 1861026. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Bug 1861026: update boot images to perform other rpm-ostree operations after OS rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants