Update error message when gather bootstrap fails from create cluster. #3256
Conversation
The gather bootstrap error message specifies to use the --key command to specify a key. When that error message is shown after running create cluster, users may think the --key flag is available in the create cluster command. Addresses: openshift#3188
openshift-ci-robot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-steps |
|
/retest |
|
/lgtm |
|
/assign @abhinavdahiya |
|
/test e2e-vsphere |
|
@patrickdillon: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| @@ -103,7 +103,7 @@ var ( | |||
| logrus.Error("Attempted to gather ClusterOperator status after installation failure: ", err2) | |||
| } | |||
| if err2 := runGatherBootstrapCmd(rootOpts.dir); err2 != nil { | |||
| logrus.Error("Attempted to gather debug logs after installation failure: ", err2) | |||
| logrus.Error("Attempted to gather debug logs after installation failure by running openshift-install gather bootstrap:", err2) | |||
There was a problem hiding this comment.
| logrus.Error("Attempted to gather debug logs after installation failure by running openshift-install gather bootstrap:", err2) | |
| logrus.Error("Failed to gather debug logs using openshift-install gather bootstrap: ", err2) |
abhinavdahiya
added
the
version/4.6
|
/close |
|
@patrickdillon: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The gather bootstrap error message specifies to use the --key command to specify a key. When that error message is shown after running create cluster, users may think the --key flag is available in the create cluster command.
Resolves: #3188
Error messages are hard... so suggestions are definitely encouraged.