images: add rhcos.json to the upi ci image #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vSphere e2e tests need to create a VM template from an OVA. The location from which to download the OVA is in the rhcos.json file. This change makes the rhcos.json file available to the CI tests.
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: staebler, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
/retest |
|
/test e2e-aws |
|
Note though this isn't how we'd expect a customer to do it...see also #1399 |
abhinavdahiya
added a commit
to abhinavdahiya/release
that referenced
this pull request
Apr 26, 2019
…image to pick bootimage upi-installer image now includes the static rhcos.json [1], such that we that pickup the required bootimage asset location directly from it. [1]: openshift/installer#1673
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vSphere e2e tests need to create a VM template from an OVA. The location from which to download the OVA is in the rhcos.json file. This change makes the rhcos.json file available to the CI tests.