CORS-3741: Nutanix enhancement: allow multiple NICs #1711
Conversation
|
@yanhua121: This pull request references CORS-3741 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
@yanhua121: This pull request references CORS-3741 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/assign @JoelSpeed |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| authors: | ||
| reviewers: | ||
| approvers: | ||
| api-approvers: |
There was a problem hiding this comment.
These need to be filled out, I can be assigned as review and api-approver. Probably this needs some installer input so @patrickdillon probably wants to be the approver here, unless he wants to delegate to another
There was a problem hiding this comment.
Yes I can be a reviewer. Also @rvanderp3 or someone from splat
There was a problem hiding this comment.
As presented, this looks pretty straight forward. The API fields already exist in the install config and also machine API. So it is mostly a matter of relaxing validation.
Are NICs handled transparently? i.e. all that needs to happen is more subnets are specified in the API and then NICs are created automagically for those subnets?
There is no reference to CAPI support. The CAPI manifests used by the installer to create the control plane would likely need to be updated as well.
| authors: | ||
| reviewers: | ||
| approvers: | ||
| api-approvers: |
There was a problem hiding this comment.
Yes I can be a reviewer. Also @rvanderp3 or someone from splat
|
@yanhua121: This pull request references CORS-3741 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
|
||
| ### API Extensions | ||
|
|
||
| Currently, the “subnets” fields in both Machine/MachineSet’s Nutanix providerSpec and Nutanix FailureDomain are already array type. The only change for the api is to relax the validation rule for the “subnets” fields to allow multiple values and to ensure no duplication values are configured. |
There was a problem hiding this comment.
Since we now use CAPI during the installation process, do we also need to make changes to the CAPI nutanix provider?
There was a problem hiding this comment.
The nutanix-capi already supports multi-subnets. And in the OCP installer code currently, the mutli-subnets as array type already handled properly when generating the nutanix-capi manifests and also the MAPI manifests. This time, the installer change is only to relax the validation (previously limit to only one subnet). See the PR openshift/installer#9133. My manual integration test with multi-subnets passed.
There was a problem hiding this comment.
Is there anything we need to be careful with software side when adding multiple subnets, any networking configuration?
There was a problem hiding this comment.
Each subnet used for the OCP cluster nodes should already exist in the Prism Element (PE) cluster of the PC. This is already documented in OCP documentation. Same requirement as before: before is limited to just one existing subnet and now can configure more than one existing subnets per PE (FailureDomain).
yanhua121
force-pushed
the
CORS-3741
branch
2 times, most recently
from
188e565
to
1c57780
Compare
|
@yanhua121: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Apart from my outstanding question about software and the markdownlint being sad, I'm ok with what's written here, thanks @huali9 |
|
/assign @rvanderp3 |
CORS-3741:
Nutanix machine-api enhancements: Multi-NICs for OCP Cluster Nodes
The enhancement PR for this:
#1711