Skip to content

Commit

Permalink
tools: remove the --full flag
Browse files Browse the repository at this point in the history
Show all data all the time.

Signed-off-by: Doug Hellmann <[email protected]>
  • Loading branch information
dhellmann committed Feb 1, 2021
1 parent 14f79b4 commit 1737c3c
Showing 1 changed file with 9 additions and 15 deletions.
24 changes: 9 additions & 15 deletions tools/cmd/report.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import (
func newReportCommand() *cobra.Command {
var (
daysBack, staleMonths int
devMode, full bool
devMode bool
)

cmd := &cobra.Command{
Expand Down Expand Up @@ -102,7 +102,7 @@ func newReportCommand() *cobra.Command {
},
}

// Define some extra buckets for the "full" report format.
// Define some extra buckets for older or lingering items
revived := stats.Bucket{
Rule: func(prd *stats.PullRequestDetails) bool {
// Anything in either of these states from
Expand Down Expand Up @@ -195,6 +195,13 @@ func newReportCommand() *cobra.Command {
report.SortByActivityCountDesc(otherActive.Requests)
report.ShowPRs("Other Active", otherActive.Requests, true)

report.SortByID(revived.Requests)
report.ShowPRs(
fmt.Sprintf("Revived (closed more than %d days ago, but with new comments)", daysBack),
revived.Requests,
false,
)

report.SortByID(otherOld.Requests)
report.ShowPRs(
fmt.Sprintf("Old (older than %d months, but discussion in last %d days)",
Expand All @@ -211,18 +218,6 @@ func newReportCommand() *cobra.Command {
false,
)

// Only print the closing sections if asked to with the --full flag
if !full {
return nil
}

report.SortByID(revived.Requests)
report.ShowPRs(
fmt.Sprintf("Revived (closed more than %d days ago, but with new comments)", daysBack),
revived.Requests,
false,
)

report.SortByID(idle.Requests)
report.ShowPRs(
fmt.Sprintf("Idle (no comments for at least %d days)", daysBack),
Expand All @@ -238,7 +233,6 @@ func newReportCommand() *cobra.Command {
cmd.Flags().IntVar(&staleMonths, "stale-months", 3,
"how many months before a pull request is considered stale")
cmd.Flags().BoolVar(&devMode, "dev", false, "dev mode, stop after first page of PRs")
cmd.Flags().BoolVar(&full, "full", false, "full report, not just summary")

return cmd
}
Expand Down

0 comments on commit 1737c3c

Please sign in to comment.