Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(reimplement) Add imagestream for driver-toolkit #62

Conversation

dagrayvid
Copy link
Contributor

@dagrayvid dagrayvid commented Sep 20, 2021

Reverts #61, which reverted #60. It can now be un-reverted because the following PR has merged openshift/kubernetes#963.

From the original PR:

This PR adds a manifests/ directory, and a manifest for an imagestream.

The imagestream contains a latest tag, and a tag for the RHCOS version corresponding to a release.
The string 0.0.1-snapshot-machine-os will be substituted with the RHCOS version in the manifest. The substitution will happen when oc adm release new ... is run, and the rhcos version is scraped from the machine-os-content.

See the oc code for information on how the substitution works. https://github.com/openshift/oc/blob/5d8dfa1c2e8e7469d69d76f21e0a166a0de8663b/pkg/cli/admin/release/image_mapper.go#L328-L334

Signed-off-by: David Gray [email protected]

/cc @kpouget

@openshift-ci openshift-ci bot requested a review from kpouget September 20, 2021 15:29
@dagrayvid dagrayvid changed the title (reimplemenet) Add imagestream for driver-toolkit (reimplement) Add imagestream for driver-toolkit Sep 20, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dagrayvid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2021
@kpouget
Copy link
Contributor

kpouget commented Sep 20, 2021

thanks @dagrayvid

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2021
@openshift-merge-robot openshift-merge-robot merged commit da8a609 into openshift:master Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants