Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sriov dp admission controller to dpu operator #172

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vrindle
Copy link
Contributor

@vrindle vrindle commented Oct 7, 2024

No description provided.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2024
@vrindle vrindle marked this pull request as draft October 7, 2024 05:55
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2024
Copy link

openshift-ci bot commented Oct 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrindle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2024
Copy link

openshift-ci bot commented Oct 7, 2024

@vrindle: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/make-test f922f9c link true /test make-test
ci/prow/make-prow-ci-manifests-check f922f9c link true /test make-prow-ci-manifests-check
ci/prow/make-fmt-check f922f9c link true /test make-fmt-check
ci/prow/make-generate-check f922f9c link true /test make-generate-check
ci/prow/images f922f9c link true /test images
ci/prow/e2e-dpu-operator-tests f922f9c link true /test e2e-dpu-operator-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vrindle vrindle force-pushed the add_sriov_dp_admission_controller branch from f922f9c to 49a01cc Compare October 7, 2024 05:58
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2024
@vrindle
Copy link
Contributor Author

vrindle commented Oct 7, 2024

WIP (unable to run make-e2e-test locally). Fixing that before removing do-not-merge label. Also WIP: add network-resource-injector detection for sriov network operator...

@vrindle vrindle force-pushed the add_sriov_dp_admission_controller branch from 49a01cc to d10cabf Compare October 7, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants