Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOSTEDCP-2032: Set azure disk & file Secrets Store CSI Volume #309

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bryan-cox
Copy link
Member

Set the azure-disk and azure-file Secrets Store CSI volumes and volume mounts when the following environment variables are passed to the csi-operator pod - ARO_HCP_SECRET_PROVIDER_CLASS_FOR_FILE, ARO_HCP_SECRET_PROVIDER_CLASS_FOR_DISK.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 23, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 23, 2024

@bryan-cox: This pull request references HOSTEDCP-2032 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target only the "4.18.0" version, but multiple target versions were set.

In response to this:

Set the azure-disk and azure-file Secrets Store CSI volumes and volume mounts when the following environment variables are passed to the csi-operator pod - ARO_HCP_SECRET_PROVIDER_CLASS_FOR_FILE, ARO_HCP_SECRET_PROVIDER_CLASS_FOR_DISK.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bryan-cox
Once this PR has been reviewed and has the lgtm label, please assign gnufied for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Set the azure-disk and azure-file Secrets Store CSI volumes and volume
mounts when the following environment variables are passed to the
csi-operator pod - ARO_HCP_SECRET_PROVIDER_CLASS_FOR_FILE,
ARO_HCP_SECRET_PROVIDER_CLASS_FOR_DISK.

Signed-off-by: Bryan Cox <[email protected]>
Copy link
Contributor

openshift-ci bot commented Oct 23, 2024

@bryan-cox: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade 4111c32 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-azure 4111c32 link true /test e2e-azure
ci/prow/e2e-azure-csi 4111c32 link true /test e2e-azure-csi
ci/prow/e2e-azure-file-csi 4111c32 link true /test e2e-azure-file-csi
ci/prow/e2e-azure-file-nfs-csi 4111c32 link true /test e2e-azure-file-nfs-csi
ci/prow/security 4111c32 link false /test security
ci/prow/e2e-azure-csi-extended 4111c32 link false /test e2e-azure-csi-extended
ci/prow/e2e-azurestack-csi 4111c32 link false /test e2e-azurestack-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bryan-cox
Copy link
Member Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants