NO-JIRA: Remove inject-proxy annotations for aws-ebs, aws-efs node daemonsets

[stephenfin]

There is no proxy hook configured for either driver making this a no-op. Remove it.

[openshift-ci-robot]

@stephenfin: This pull request explicitly references no jira issue.

In response to this:

There is no proxy hook configured for either driver making this a no-op. Remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stephenfin
Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[stephenfin]

@jsafrane @gnufied I've only removed the config.openshift.io/inject-proxy: csi-driver annotation here. However, I'm wondering if I should also remove the config.openshift.io/inject-proxy-cabundle: csi-driver annotation and the associated hook from both drivers. Based on feedback in #304, we're saying that the drivers don't need access to the cloud on the node and there is therefore no need for a proxy hook. If this is the case, what is the reason for injecting CA bundles into the containers?

csi-operator/pkg/driver/aws-ebs/aws_ebs.go

Lines 314 to 325 in e71aab2

	// withCABundleDaemonSetHook projects custom CA bundle ConfigMap into the CSI driver container
	func withCABundleDaemonSetHook(c *clients.Clients) (csidrivernodeservicecontroller.DaemonSetHookFunc, []factory.Informer) {
	hook := csidrivernodeservicecontroller.WithCABundleDaemonSetHook(
	c.GuestNamespace,
	trustedCAConfigMap,
	c.GetConfigMapInformer(c.GuestNamespace),
	)
	informers := []factory.Informer{
	c.GetConfigMapInformer(c.GuestNamespace).Informer(),
	}
	return hook, informers
	}

which resolves to the below that explicitly references use for proxies:

https://github.com/openshift/library-go/blob/abb8c75b88dcba14fb3b27f6bf47388d3fc71ca2/pkg/operator/csi/csidrivernodeservicecontroller/helpers.go#L50-L60

Should I also be dropping the config.openshift.io/inject-proxy-cabundle: csi-driver annotation and the withCABundleDaemonSetHook hook?

[stephenfin]

/retest-required

[openshift-ci]

@stephenfin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	9813dde	link	false	/test security
ci/prow/e2e-azurestack-csi	9813dde	link	false	/test e2e-azurestack-csi
ci/prow/smb-operator-e2e	9813dde	link	false	/test smb-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.