-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-42325: Set separate secrets for file and disk config on HyperShift #290
base: master
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
It's a good idea to separate these secrets, is there a corresponding hypershift PR that creates those secrets? |
Hey @jan--f - there isn't a PR at the moment but there will be in the near future. HyperShift would be responsible for creating/reconciling that within the HCP namespace. |
I opened openshift/hypershift#4861 for now to correlate to this PR. |
/retest |
@bryan-cox: This pull request references HOSTEDCP-2033 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target only the "4.18.0" version, but multiple target versions were set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Set separate secrets for file and disk authentication config for Azure. Previously, these two components were reusing the same configuration as cloud provider. Signed-off-by: Bryan Cox <[email protected]>
c18537e
to
12d3bc3
Compare
/retest |
@bryan-cox: This pull request references Jira Issue OCPBUGS-42325, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@bryan-cox: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
/label docs-approved |
@bryan-cox: This pull request references Jira Issue OCPBUGS-42325, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Will do some intergration test with hypershift QE guys later when the configuration of cluster could be created. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Set separate secrets for file and disk authentication config for Azure. Previously, these two components were reusing the same configuration as cloud provider.