Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-42325: Set separate secrets for file and disk config on HyperShift #290

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bryan-cox
Copy link
Member

Set separate secrets for file and disk authentication config for Azure. Previously, these two components were reusing the same configuration as cloud provider.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2024
Copy link
Contributor

openshift-ci bot commented Oct 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jsafrane
Copy link
Contributor

jsafrane commented Oct 8, 2024

It's a good idea to separate these secrets, is there a corresponding hypershift PR that creates those secrets?

@bryan-cox
Copy link
Member Author

It's a good idea to separate these secrets, is there a corresponding hypershift PR that creates those secrets?

Hey @jan--f - there isn't a PR at the moment but there will be in the near future. HyperShift would be responsible for creating/reconciling that within the HCP namespace.

@bryan-cox
Copy link
Member Author

I opened openshift/hypershift#4861 for now to correlate to this PR.

@bryan-cox bryan-cox changed the title Set secrets for file and disk config on HyperShift Set separate secrets for file and disk config on HyperShift Oct 9, 2024
@bryan-cox bryan-cox marked this pull request as ready for review October 10, 2024 16:56
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2024
@bryan-cox
Copy link
Member Author

/retest

@bryan-cox bryan-cox changed the title Set separate secrets for file and disk config on HyperShift HOSTEDCP-2033: Set separate secrets for file and disk config on HyperShift Oct 19, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 19, 2024

@bryan-cox: This pull request references HOSTEDCP-2033 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target only the "4.18.0" version, but multiple target versions were set.

In response to this:

Set separate secrets for file and disk authentication config for Azure. Previously, these two components were reusing the same configuration as cloud provider.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Set separate secrets for file and disk authentication config for Azure.
Previously, these two components were reusing the same configuration as
cloud provider.

Signed-off-by: Bryan Cox <[email protected]>
@bryan-cox
Copy link
Member Author

/retest

@bryan-cox bryan-cox changed the title HOSTEDCP-2033: Set separate secrets for file and disk config on HyperShift OCPBUGS-42325: Set separate secrets for file and disk config on HyperShift Oct 22, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 22, 2024
@openshift-ci-robot
Copy link

@bryan-cox: This pull request references Jira Issue OCPBUGS-42325, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Set separate secrets for file and disk authentication config for Azure. Previously, these two components were reusing the same configuration as cloud provider.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Oct 22, 2024

@bryan-cox: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 12d3bc3 link false /test security
ci/prow/e2e-azurestack-csi 12d3bc3 link false /test e2e-azurestack-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jsafrane
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2024
@Phaow
Copy link
Contributor

Phaow commented Oct 24, 2024

/label docs-approved
/label px-approved
/label qe-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Oct 24, 2024
@openshift-ci-robot
Copy link

@bryan-cox: This pull request references Jira Issue OCPBUGS-42325, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

Set separate secrets for file and disk authentication config for Azure. Previously, these two components were reusing the same configuration as cloud provider.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Phaow
Copy link
Contributor

Phaow commented Oct 24, 2024

Will do some intergration test with hypershift QE guys later when the configuration of cluster could be created.

@jsafrane
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Oct 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants