-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONSOLE-2391: Monitoring: Add i18n for Metrics and Dashboards pages #7266
CONSOLE-2391: Monitoring: Add i18n for Metrics and Dashboards pages #7266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold for approvals
/assign @yapei @ahardin-rh @sferich888
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/label docs-approved |
@schituku That is expected because the actual string translations have not been added yet. This PR just makes the strings available for translating, but doesn't include the actual translations. |
@kyoto Won't those chart titles be marked for translation on dashboards page? |
@yanpzhan No, the dashboard content itself will not be translated at this time. Those are defined in config maps contributed by the monitoring operator and are out of scope for the initial i18n work. What you have in the screenshot is what I would expect. |
/label qe-approved |
If this is the case we need to make sure the release notes for i18n denotes this. @codyhoag can you make sure that we capture this in some way? /label px-approved |
@ahardin-rh -- @sferich888 suggested we should release note this. There are a few other places where things won't be translated as well such as content coming from operators in OperatorHub. |
I have added this to the release notes tracker so we don't miss this openshift/openshift-docs#26801 (comment). @ahardin-rh feel free to mark it as done in the tracker if you take care of the release note. Thanks! |
0cf46e4
to
24c2b0d
Compare
Rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
We'll need to wait until our bugs are under our SLO before we can merge.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtaylor113, kyoto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Removing the hold since we're below our SLO. /hold cancel |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
No description provided.