Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Test apply operator status #506

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

WIP: Test apply operator status #506

wants to merge 13 commits into from

Conversation

bertinatto
Copy link
Member

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2024
@bertinatto bertinatto force-pushed the try-apply branch 2 times, most recently from daeaf1e to c8af0c0 Compare September 26, 2024 16:18
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2024
@bertinatto
move to generic operator client
b4003d7
@bertinatto
move olmremovalcontroller to generic operator client
2813ae4
@bertinatto
Refactor utils.CreateDeployment() to use Server-Side Apply (SSA)
68f6bdc 
Use SSA for updating OperatorStatus. Although the function doesn’t
appear to be in use, it is exported and may have external consumers.
@bertinatto
Refactor CommonCSIDeploymentController to use SSA to update OperatorS…
4234dbb 
…tatus
@bertinatto
Refactor DefaultStorageClassController to use SSA to update OperatorS…
1772781 
…tatus
@bertinatto
Refactor CSIDriverOperatorCRController to use SSA to update OperatorS…
f09dc33 
…tatus
@bertinatto
Refactor OLMOperatorRemovalController to use SSA to update OperatorSt…
438abad 
…atus
@bertinatto
Refactor VSphereProblemDetectorMonitoringController to use SSA to upd…
858bd10 
…ate OperatorStatus
@bertinatto
Refactor driver starter to use SSA to update OperatorStatus
a542ed7
@bertinatto
Add missing error check
067a279
@bertinatto
start generic informers
6b7dc12
@bertinatto
Bump api, client-go and library-go
8532a86
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 27, 2024

@bertinatto: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-csi e45fbff link true /test e2e-gcp-csi
ci/prow/e2e-openstack-parallel e45fbff link false /test e2e-openstack-parallel
ci/prow/e2e-aws-ovn-upgrade e45fbff link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-ibmcloud-csi e45fbff link false /test e2e-ibmcloud-csi
ci/prow/hypershift-aws-e2e-external e45fbff link true /test hypershift-aws-e2e-external
ci/prow/e2e-azure-file-csi e45fbff link true /test e2e-azure-file-csi
ci/prow/e2e-openstack e45fbff link false /test e2e-openstack
ci/prow/unit e45fbff link true /test unit
ci/prow/e2e-gcp-manual-oidc e45fbff link false /test e2e-gcp-manual-oidc
ci/prow/e2e-vsphere-csi e45fbff link true /test e2e-vsphere-csi
ci/prow/e2e-azure-csi e45fbff link true /test e2e-azure-csi
ci/prow/e2e-aws-csi e45fbff link true /test e2e-aws-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied Awaiting requested review from gnufied

@RomanBednar RomanBednar Awaiting requested review from RomanBednar

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bertinatto @openshift-merge-robot