MON-4042: new label for acm_console_page_count metric #2491
Conversation
zlayne
commented
Oct 3, 2024
zlayne
commented
- I added CHANGELOG entry for this change.
- No user facing changes, so no entry in CHANGELOG was needed.
Signed-off-by: zlayne <[email protected]>
Signed-off-by: zlayne <[email protected]>
|
@zlayne: This pull request references MON-4042 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zlayne The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: zlayne <[email protected]>
|
@zlayne: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| @@ -758,7 +758,7 @@ data: | |||
| # owners: (https://github.com/orgs/stolostron/teams/search-admin, @acm-observability-search) | |||
| # | |||
| # acm_console_page_count:sum counts the total number of visits for each page in ACM console. | |||
| - '{__name__="acm_console_page_count:sum", page=~"overview-classic|overview-fleet|search|search-details|clusters|application|governance"}' | |||
| - '{__name__="acm_console_page_count:sum", page=~"overview-fleet|search|search-details|clusters|virtual-machines|application|governance"}' | |||
There was a problem hiding this comment.
you probably want to keep the deprecated overview-classic label because otherwise it might be removed from the Telemeter server allow-list (need @saswatamcode @philipgough confirmation here). But a comment + TODO would be useful.
There was a problem hiding this comment.
@simonpasquier thanks for the comment. If we remove the overview-classic label here will we lose history? If not then we are okay not to receive any new data.
