OCPBUGS-41892: Single Watch on GWAPI CRD #1165
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
jira/severity-moderate
|
@Thealisyed: This pull request references Jira Issue OCPBUGS-41892, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@Thealisyed: This pull request references Jira Issue OCPBUGS-41892, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-aws-ovn-single-node |
|
/retest-required |
Thealisyed
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
There was a problem hiding this comment.
(Whoops, I've had this review pending, waiting for me to submit it, for 5 days...)
Is it true that the existing watch only generates reconciliation requests when the Gateway API feature is not enabled?
In any case, please add a little more detail in the commit message. For example:
gatewayapi: Use single watch for CRDs
Replace the multiple watches for Gateway API CRDs with a single CRD watch, with
a predicate to filter CRDs based on the gatewayapiv1.GroupName. This ensures
that only relevant CRDs are watched, reducing unnecessary reconciliation
requests and log messages.
This commit fixes OCPBUGS-41892.
https://issues.redhat.com/browse/OCPBUGS-41892
Miciah
added
the
priority/backlog
|
/assign |
|
@Thealisyed please investigate the failures in the CI tests, especially e2e-aws-gatewayapi, which is the GWAPI test. I ran a retest to see if the issue with imagestreams had gone away. |
|
/retest |
|
@Thealisyed please note you will need to squash your three commits before merge. |
|
Process did not finish before 4h0m0s timeout /test e2e-aws-ovn-serial |
…used toFeatureGate function
Thealisyed
force-pushed
the
watcher-fix
branch
from
328eeeb
to
56367cc
Compare
|
/approve The changes look fine to me. I did have a suggestion for the commit message: #1165 (review). We generally follow the upstream conventions: https://www.kubernetes.dev/docs/guide/pull-requests/#commit-message-guidelines |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test e2e-aws-ovn-techpreview |
|
@Thealisyed: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
A single CRD watch was added with a predicate to filter CRDs based on the gatewayapiv1.GroupName. This ensures that only relevant CRDs are watched, reducing unnecessary logging when the Gateway API feature is not enabled.