Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NE-1504: Enable Azure MSI authentication for ARO HCP #1119

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

bryan-cox
Copy link
Member

For ARO HCP, we need to override the authentication type to be MSI. For more information please see openshift/enhancements#1659.

For ARO HCP, we need to override the authentication type to be MSI. For more information please see openshift/enhancements#1659.
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 5, 2024

@bryan-cox: This pull request references NE-1688 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

For ARO HCP, we need to override the authentication type to be MSI. For more information please see openshift/enhancements#1659.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 5, 2024
Copy link
Contributor

openshift-ci bot commented Aug 5, 2024

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Miciah
Copy link
Contributor

Miciah commented Aug 6, 2024

Thanks!
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2024
@Miciah
Copy link
Contributor

Miciah commented Aug 6, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 6f7dd70 into openshift:master Aug 6, 2024
17 checks passed
@bryan-cox bryan-cox deleted the NE-1688 branch August 6, 2024 19:43
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-ingress-operator
This PR has been included in build ose-cluster-ingress-operator-container-v4.17.0-202408062045.p0.g6f7dd70.assembly.stream.el9.
All builds following this will include this PR.

@candita
Copy link
Contributor

candita commented Aug 15, 2024

This work was done for NE-1504.
/retitle NE-1504: Enable Azure MSI authentication for ARO HCP

@openshift-ci openshift-ci bot changed the title NE-1688: Enable Azure MSI authentication for ARO HCP NE-1504: Enable Azure MSI authentication for ARO HCP Aug 15, 2024
@Miciah
Copy link
Contributor

Miciah commented Aug 29, 2024

This work was done for NE-1504. /retitle NE-1504: Enable Azure MSI authentication for ARO HCP

I usually link a PR with a task, story, or bug, not with an epic (or feature). Have I been doing it wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants