Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Stop using the manifest-tool secrets in jobs #4404

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP Stop using the manifest-tool secrets in jobs #4404

wants to merge 1 commit into from
+42 −68

Conversation

droslean
Copy link
Member

/hold

/cc @deepsm007 @openshift/test-platform

@openshift-ci openshift-ci bot requested review from deepsm007 and a team November 13, 2024 13:30
@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 13, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007, droslean

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

New changes are detected. LGTM label has been removed.

@droslean droslean force-pushed the manifest-tool-depr-3 branch 2 times, most recently from 82c3cd4 to 75dd074 Compare November 13, 2024 13:48
@droslean
Copy link
Member Author

/test e2e

@droslean
Copy link
Member Author

/test e2e

@droslean droslean mentioned this pull request Nov 13, 2024
Merged
@droslean droslean force-pushed the manifest-tool-depr-3 branch 2 times, most recently from 9a0f748 to 63f7d6f Compare November 14, 2024 13:57
@droslean droslean changed the title WIP prowgen: stop mounting the manifest-tool secrets in jobs WIP prowgen: stop using the manifest-tool secrets in jobs Nov 14, 2024
@droslean droslean changed the title WIP prowgen: stop using the manifest-tool secrets in jobs WIP Stop using the manifest-tool secrets in jobs Nov 14, 2024
@droslean
Copy link
Member Author

/test e2e

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 15, 2024

@droslean: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/breaking-changes 18ec83a link false /test breaking-changes
ci/prow/unit 18ec83a link true /test unit
ci/prow/integration 18ec83a link true /test integration
ci/prow/security 18ec83a link false /test security
ci/prow/e2e 18ec83a link true /test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepsm007 deepsm007 deepsm007 approved these changes

Assignees

@deepsm007 deepsm007

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@droslean @deepsm007