Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FLs and TLs as approvers #835

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmazur
Copy link
Member

@mmazur mmazur commented Oct 30, 2024

Make FLs and TLs approvers for cases where standard approvers aren't suitable/are hard to come by.

Ref OSD-25197

Copy link
Contributor

openshift-ci bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmazur
Once this PR has been reviewed and has the lgtm label, please assign dkeohane for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Oct 30, 2024

@mmazur: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.04%. Comparing base (4c2872b) to head (fc38444).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #835   +/-   ##
=======================================
  Coverage   47.04%   47.04%           
=======================================
  Files          45       45           
  Lines        6723     6723           
=======================================
  Hits         3163     3163           
  Misses       3229     3229           
  Partials      331      331           

@joshbranham
Copy link
Contributor

Do we need this once #836 merges, which includes updated boilerplate for OWNERS_ALIASES?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants