NO-ISSUE: OCPBUGS-43352 calculate outgoing interface for arping

[eifrach]

• arping is running on interfaces that are not in the same address range as the remote IP.
  In some proxy-arp enabled networks this causes false-positive IP duplication error.

This PR will validate the remote IP is in the same network as the outgoing interface

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@eifrach: This pull request references Jira Issue OCPBUGS-43352, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[eifrach]

/test ?

[openshift-ci]

@eifrach: The following commands are available to trigger required jobs:

/test e2e-agent-compact-ipv4

/test edge-e2e-ai-operator-ztp

/test edge-e2e-metal-assisted-4-18

/test edge-images

/test edge-lint

/test edge-subsystem-test

/test edge-unit-test

/test images

/test mce-images

The following commands are available to trigger optional jobs:

/test e2e-agent-4control-ipv4

/test e2e-agent-5control-ipv4

/test e2e-agent-ha-dualstack

/test e2e-agent-sno-ipv6

/test edge-e2e-metal-assisted-cnv-4-17

/test edge-e2e-metal-assisted-day2-4-18

/test edge-e2e-metal-assisted-external-4-18

/test edge-e2e-metal-assisted-ipv6-4-18

/test edge-e2e-metal-assisted-lvm-4-18

/test edge-e2e-metal-assisted-odf-4-17

/test edge-e2e-metal-assisted-single-node-4-18

/test edge-e2e-metal-assisted-upgrade-agent-4-18

/test edge-e2e-oci-assisted-4-17

/test edge-e2e-oci-assisted-4-18

/test edge-publish-multi-arch-images-dry-run

/test okd-scos-e2e-aws-ovn

/test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-assisted-installer-agent-master-e2e-agent-compact-ipv4

pull-ci-openshift-assisted-installer-agent-master-edge-e2e-ai-operator-ztp

pull-ci-openshift-assisted-installer-agent-master-edge-e2e-metal-assisted-4-18

pull-ci-openshift-assisted-installer-agent-master-edge-e2e-metal-assisted-cnv-4-17

pull-ci-openshift-assisted-installer-agent-master-edge-e2e-metal-assisted-day2-4-18

pull-ci-openshift-assisted-installer-agent-master-edge-e2e-metal-assisted-ipv6-4-18

pull-ci-openshift-assisted-installer-agent-master-edge-e2e-metal-assisted-lvm-4-18

pull-ci-openshift-assisted-installer-agent-master-edge-e2e-metal-assisted-odf-4-17

pull-ci-openshift-assisted-installer-agent-master-edge-e2e-metal-assisted-single-node-4-18

pull-ci-openshift-assisted-installer-agent-master-edge-e2e-metal-assisted-upgrade-agent-4-18

pull-ci-openshift-assisted-installer-agent-master-edge-e2e-oci-assisted-4-18

pull-ci-openshift-assisted-installer-agent-master-edge-images

pull-ci-openshift-assisted-installer-agent-master-edge-lint

pull-ci-openshift-assisted-installer-agent-master-edge-subsystem-test

pull-ci-openshift-assisted-installer-agent-master-edge-unit-test

pull-ci-openshift-assisted-installer-agent-master-images

pull-ci-openshift-assisted-installer-agent-master-mce-images

pull-ci-openshift-assisted-installer-agent-master-okd-scos-e2e-aws-ovn

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[eifrach]

/test e2e-agent-compact-ipv4
/test edge-subsystem-test

[eifrach]

/test e2e-agent-compact-ipv4
/test edge-subsystem-test
/test images
/test edge-lint
/test edge-unit-test

[codecov]

Codecov Report

Attention: Patch coverage is 69.56522% with 14 lines in your changes missing coverage. Please review.

Project coverage is 60.47%. Comparing base (8d7bc11) to head (258fdb0).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
src/connectivity_check/ipv4_arping_checker.go	69.56%	10 Missing and 4 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #877      +/-   ##
==========================================
- Coverage   60.54%   60.47%   -0.07%     
==========================================
  Files          75       75              
  Lines        3992     4003      +11     
==========================================
+ Hits         2417     2421       +4     
- Misses       1405     1410       +5     
- Partials      170      172       +2     

Files with missing lines	Coverage Δ
src/connectivity_check/ipv4_arping_checker.go	77.27% <69.56%> (-4.55%)	⬇️

... and 1 file with indirect coverage changes

[eifrach]

/test e2e-agent-compact-ipv4
/test edge-subsystem-test
/test images
/test edge-lint
/test edge-unit-test

[eifrach]

/test e2e-agent-compact-ipv4
/test edge-unit-test

[paul-maidment]

/lgtm

[eifrach]

/override ci/prow/edge-e2e-oci-assisted-4-18

[paul-maidment]

/lgtm

[openshift-ci]

@eifrach: Overrode contexts on behalf of eifrach: ci/prow/edge-e2e-oci-assisted-4-18

In response to this:

/override ci/prow/edge-e2e-oci-assisted-4-18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eifrach, paul-maidment

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [eifrach,paul-maidment]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[eifrach]

/override ci/prow/edge-e2e-oci-assisted-4-18

[openshift-ci]

@eifrach: Overrode contexts on behalf of eifrach: ci/prow/edge-e2e-oci-assisted-4-18

In response to this:

/override ci/prow/edge-e2e-oci-assisted-4-18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[eifrach]

/override ci/prow/okd-scos-e2e-aws-ovn

[openshift-ci]

@eifrach: Overrode contexts on behalf of eifrach: ci/prow/okd-scos-e2e-aws-ovn

In response to this:

/override ci/prow/okd-scos-e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@eifrach: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[eifrach]

/jira refresh

[openshift-ci-robot]

@eifrach: This pull request references Jira Issue OCPBUGS-43352, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[eifrach]

/jira refresh

[openshift-ci-robot]

@eifrach: This pull request references Jira Issue OCPBUGS-43352, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[eifrach]

/jira refresh

[openshift-ci-robot]

@eifrach: This pull request references Jira Issue OCPBUGS-43352, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[eifrach]

/jira refresh

[openshift-ci-robot]

@eifrach: This pull request references Jira Issue OCPBUGS-43352, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@eifrach: This pull request explicitly references no jira issue.

In response to this:

• arping is running on interfaces that are not in the same address range as the remote IP.
  In some proxy-arp enabled networks this causes false-positive IP duplication error.

This PR will validate the remote IP is in the same network as the outgoing interface

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[eifrach]

/jira refresh

[openshift-ci-robot]

@eifrach: This pull request explicitly references no jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-agent-installer-node-agent
This PR has been included in build ose-agent-installer-node-agent-container-v4.19.0-202501071907.p0.gdd3ad96.assembly.stream.el9.
All builds following this will include this PR.