-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS_45910: Fix cpu clockspeed for s390x #857
base: master
Are you sure you want to change the base?
OCPBUGS_45910: Fix cpu clockspeed for s390x #857
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #857 +/- ##
==========================================
- Coverage 60.54% 60.49% -0.06%
==========================================
Files 75 75
Lines 3992 3992
==========================================
- Hits 2417 2415 -2
- Misses 1405 1406 +1
- Partials 170 171 +1
|
/retest |
2 similar comments
/retest |
/retest |
57ee99b
to
bd5c5ec
Compare
/retest |
1 similar comment
/retest |
bd5c5ec
to
e7b2a0e
Compare
e7b2a0e
to
603b7ac
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: apodvrat The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…del Name Signed-off-by: Amadeus Podvratnik <[email protected]>
603b7ac
to
914474f
Compare
/retest |
@apodvrat: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
For s390x architectures lscpu does not return the clock speed by "CPU MHz" or "CPU max MHz" field but have two fields (CPU static MHz and CPU dynamic MHz).
"CPU static MHz" is the field representing the designed clock speed whereas the "CPU dynamic MHz" is representing the current CPU speed (throttled or energy saving).
New test case for s390x architecture was added.
In addition the machine type was fixed, too.
The fix was tested using unit tests:
JUnit path was configured: ./junit_unit_test.xml
JUnit report was created: /root/code/Assisted_Installer/latest/assisted-installer-agent/src/inventory/junit_unit_test.xml
Ran 121 of 121 Specs in 0.268 seconds
SUCCESS! -- 121 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestInventory (0.30s)