Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS_45910: Fix cpu clockspeed for s390x #857

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

apodvrat
Copy link
Contributor

@apodvrat apodvrat commented Dec 16, 2024

For s390x architectures lscpu does not return the clock speed by "CPU MHz" or "CPU max MHz" field but have two fields (CPU static MHz and CPU dynamic MHz).
"CPU static MHz" is the field representing the designed clock speed whereas the "CPU dynamic MHz" is representing the current CPU speed (throttled or energy saving).
New test case for s390x architecture was added.
In addition the machine type was fixed, too.

The fix was tested using unit tests:

JUnit path was configured: ./junit_unit_test.xml

JUnit report was created: /root/code/Assisted_Installer/latest/assisted-installer-agent/src/inventory/junit_unit_test.xml

Ran 121 of 121 Specs in 0.268 seconds
SUCCESS! -- 121 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestInventory (0.30s)

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.49%. Comparing base (ecb65f1) to head (914474f).
Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #857      +/-   ##
==========================================
- Coverage   60.54%   60.49%   -0.06%     
==========================================
  Files          75       75              
  Lines        3992     3992              
==========================================
- Hits         2417     2415       -2     
- Misses       1405     1406       +1     
- Partials      170      171       +1     
Files with missing lines Coverage Δ
src/inventory/cpu.go 93.10% <100.00%> (ø)

... and 1 file with indirect coverage changes

@AmadeusPodvratnik
Copy link
Contributor

/retest

2 similar comments
@AmadeusPodvratnik
Copy link
Contributor

/retest

@apodvrat
Copy link
Contributor Author

/retest

@apodvrat apodvrat force-pushed the OCPBUGS_45910_s390x_fix_cpu_clockspeed branch from 57ee99b to bd5c5ec Compare December 17, 2024 16:10
@apodvrat
Copy link
Contributor Author

/retest

1 similar comment
@AmadeusPodvratnik
Copy link
Contributor

/retest

@apodvrat apodvrat force-pushed the OCPBUGS_45910_s390x_fix_cpu_clockspeed branch from bd5c5ec to e7b2a0e Compare December 18, 2024 13:48
src/inventory/cpu_test.go Outdated Show resolved Hide resolved
@apodvrat apodvrat force-pushed the OCPBUGS_45910_s390x_fix_cpu_clockspeed branch from e7b2a0e to 603b7ac Compare December 19, 2024 08:53
Copy link

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: apodvrat
Once this PR has been reviewed and has the lgtm label, please ask for approval from paul-maidment. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@apodvrat apodvrat force-pushed the OCPBUGS_45910_s390x_fix_cpu_clockspeed branch from 603b7ac to 914474f Compare December 19, 2024 15:07
@apodvrat
Copy link
Contributor Author

/retest

Copy link

openshift-ci bot commented Dec 20, 2024

@apodvrat: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/edge-e2e-oci-assisted-4-18 914474f link false /test edge-e2e-oci-assisted-4-18
ci/prow/okd-scos-e2e-aws-ovn 914474f link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants