Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example format validation #2110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add example format validation #2110

wants to merge 1 commit into from
+115 −1

Conversation

JoelSpeed
Copy link
Contributor

This adds an example of the new format library for validating DNS 1123 subdomains to the example API. Will be leveraging this few a through APIs so providing an example hopefully helps some folks.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

Hello @JoelSpeed! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 26, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2024
@yuqi-zhang
Copy link
Contributor

/lgtm

Matches upstream examples

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 98fc036 and 2 for PR HEAD 789119b in total

3 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 98fc036 and 2 for PR HEAD 789119b in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 98fc036 and 2 for PR HEAD 789119b in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 98fc036 and 2 for PR HEAD 789119b in total

@yuqi-zhang
Copy link
Contributor

Verify seems to be failing on some generated lines having an extra \\ ?

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 98fc036 and 2 for PR HEAD 789119b in total

2 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 98fc036 and 2 for PR HEAD 789119b in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 98fc036 and 2 for PR HEAD 789119b in total

@JoelSpeed
Copy link
Contributor Author

/hold

Broken generation, will re-push and unhold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 27, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 27, 2024

New changes are detected. LGTM label has been removed.

@JoelSpeed
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 27, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 27, 2024

@JoelSpeed: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees Awaiting requested review from bparees

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@yuqi-zhang yuqi-zhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoelSpeed @yuqi-zhang @openshift-ci-robot