Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFE-1168: Add CMPSMachineNamePrefix feature-gate #2094

Merged
merged 1 commit into from
Nov 26, 2024
Merged

CFE-1168: Add CMPSMachineNamePrefix feature-gate #2094

merged 1 commit into from
Nov 26, 2024
+27 −0

Conversation

chiragkyal
Copy link
Member

Add new CMPSMachineNamePrefix feature-gate to guard the implementation changes done to support customized control plane machine names.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 11, 2024 •
edited by openshift-ci bot
Loading

@chiragkyal: This pull request references CFE-1168 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Add new CMPSMachineNamePrefix feature-gate to guard the implementation changes done to support customized control plane machine names.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 11, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 11, 2024

Hello @chiragkyal! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 11, 2024
@chiragkyal
Copy link
Member Author

/assign @JoelSpeed

@chiragkyal chiragkyal mentioned this pull request Nov 11, 2024
Open
@chiragkyal
Copy link
Member Author

/test e2e-aws-serial-techpreview

JoelSpeed
JoelSpeed reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to make sure to use the correct jira bug component for this FG

features/features.go Outdated
@@ -219,6 +219,14 @@ var (
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
mustRegister()

FeatureGateCMPSMachineNamePrefix = newFeatureGate("CMPSMachineNamePrefix").
reportProblemsToJiraComponent("cloud-provider").
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
reportProblemsToJiraComponent("cloud-provider").
reportProblemsToJiraComponent("Cloud Compute / ControlPlaneMachineSet").

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. I've updated the Jira component.

@chiragkyal
Copy link
Member Author

@JoelSpeed this can also be merged, I believe.

@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chiragkyal, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2024
@chiragkyal
Copy link
Member Author

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

@chiragkyal: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 807d6df into openshift:master Nov 26, 2024
20 checks passed
@chiragkyal chiragkyal deleted the cmps-gate branch November 26, 2024 14:21
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.19.0-202411261618.p0.g807d6df.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@bparees bparees Awaiting requested review from bparees

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chiragkyal @openshift-ci-robot @JoelSpeed @openshift-bot